[libcxx-commits] [libcxx] [libc++] Add internal checks for some basic_streambuf invariants (PR #144602)

[Louis Dionne via libcxx-commits]

ldionne wrote:

I'm a bit conflicted: on the one hand these invariant checks are extremely useful (especially when debugging tricky issues), but on the other hand they're somewhat clunky. We could also technically do this in all methods of all classes in the library, and clearly we don't want to go down that route.

@philnik777 Do you have thoughts on this? I could also scale it down to just the two methods where checking these invariants is really helpful to debug the issue I'm looking into.

https://github.com/llvm/llvm-project/pull/144602