[libcxx-commits] [libcxx] [libc++][format] Don't instantiate direct `__(u)int128_t` visitation (PR #139662)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 13 00:17:44 PDT 2025


================
@@ -91,7 +91,7 @@ _LIBCPP_HIDE_FROM_ABI constexpr uint32_t __substitute_arg_id(basic_format_arg<_C
   // This means the 128-bit will not be valid anymore.
   // TODO FMT Verify this resolution is accepted and add a test to verify
   //          128-bit integrals fail and switch to visit_format_arg.
-  return std::__visit_format_arg(
+  return std::__visit_format_arg<__format::__directly_visit_i128::__yes>(
----------------
frederick-vs-ja wrote:

I think the TODO should be removed and the comment above should be updated.

https://github.com/llvm/llvm-project/pull/139662


More information about the libcxx-commits mailing list