[libcxx-commits] [libcxx] [libc++][format] Don't instantiate direct `__(u)int128_t` visitation (PR #139662)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 12 10:09:24 PDT 2025


================
@@ -166,7 +181,10 @@ _LIBCPP_HIDE_FROM_ABI _Rp __visit_format_arg(_Visitor&& __vis, basic_format_arg<
     return std::invoke_r<_Rp>(std::forward<_Visitor>(__vis), __arg.__value_.__long_long_);
   case __format::__arg_t::__i128:
 #    if _LIBCPP_HAS_INT128
-    return std::invoke_r<_Rp>(std::forward<_Visitor>(__vis), __arg.__value_.__i128_);
+  {
+    typename __basic_format_arg_value<_Context>::__handle __h{__arg.__value_.__u128_};
----------------
ldionne wrote:

Should this be:

```suggestion
    typename __basic_format_arg_value<_Context>::__handle __h{__arg.__value_.__i128_};
```

instead?

https://github.com/llvm/llvm-project/pull/139662


More information about the libcxx-commits mailing list