[libcxx-commits] [libcxx] [libc++] P2944R3: Constrained comparisons - update `reference_wrapper` implementation (PR #139368)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 12 05:11:48 PDT 2025


https://github.com/philnik777 approved this pull request.

> > Can we split this into multiple patches? There seems to be a lot of diff which isn't really related to the actual changes made. Especially the `HasOperatorEqual` and `HasOperatorSpaceship` canonicalizations change a lot of stuff but isn't really related to the actual changes. The changes to `generate_feature_test_macros` and the generated files of that as well.
> 
> I removed the changes related to `std::expected`. Should I resubmit them?

Feel free to. While I like simplifications in the headers more, I'm not against them in the tests. I just want to keep functional patches as small as possible to make it obvious where these functional changes are.

https://github.com/llvm/llvm-project/pull/139368


More information about the libcxx-commits mailing list