[libcxx-commits] [libcxx] [libc++] Fix return type of ilogb(double) (PR #150374)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 25 10:33:53 PDT 2025


================
@@ -58,7 +58,7 @@ inline _LIBCPP_HIDE_FROM_ABI double log10(_A1 __x) _NOEXCEPT {
 inline _LIBCPP_HIDE_FROM_ABI int ilogb(float __x) _NOEXCEPT { return __builtin_ilogbf(__x); }
 
 template <class = int>
-_LIBCPP_HIDE_FROM_ABI double ilogb(double __x) _NOEXCEPT {
+_LIBCPP_HIDE_FROM_ABI int ilogb(double __x) _NOEXCEPT {
----------------
ldionne wrote:

IIUC then the test would fail if a libc didn't provide the `double` overload, correct? We just happen not to have test coverage for that.

https://github.com/llvm/llvm-project/pull/150374


More information about the libcxx-commits mailing list