[libcxx-commits] [libcxx] [libc++] Add missing CPO tests for range adaptors (PR #149557)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 24 10:21:30 PDT 2025


ldionne wrote:

> > It seems that `static_assert(test(std::views::repeat, 1));` wasn't guarded and compiled in C++20. Perhaps we can look into this later.
> 
> No. It didn't. It seems that the generic-cxx20 set just didn't run in CI...

It definitely ran on the latest version of the patch: https://github.com/llvm/llvm-project/actions/runs/16436783672/job/46449613521?pr=149557

> > Thanks! I pushed some conflict-resolving changes.
> 
> Excuse me for the off-topic question. What is required to push to other people's PR like that? I tried to push into mine Zingam -> H-G-Hristov and I got "no access" error or similar?

I think you might need to be marked as a "maintainer" of the repo, perhaps by being in the `reviewers-libcxx` group. I'm not certain.

https://github.com/llvm/llvm-project/pull/149557


More information about the libcxx-commits mailing list