[libcxx-commits] [libcxx] [libc++] P2944R3: Constrained comparisons - `optional` (PR #144249)

[Hristo Hristov via libcxx-commits]

================
@@ -30,6 +30,13 @@ template <class _Tp, class _Up>
 struct __is_core_convertible<_Tp, _Up, decltype(static_cast<void (*)(_Up)>(0)(static_cast<_Tp (*)()>(0)()))>
     : true_type {};
 
+#if _LIBCPP_STD_VER >= 17
+
+template <class _Tp>
----------------
H-G-Hristov wrote:

@frederick-vs-ja I implemented `__is_core_convertible_v` for C++17 onward  similar to other traits. I don't understand why you suggest to do it in reverse? Everything seems fine as it is right now. Also we have the concept `__core_convertible_to`, do we want to keep it or replace it with `__is_core_convertible_v` for insignificant code reduction (of redundancy)?

https://github.com/llvm/llvm-project/pull/144249