[libcxx-commits] [libcxx] [libc++] Fix std::make_exception_ptr interaction with ObjC (PR #135386)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 4 10:46:49 PDT 2025


itrofimow wrote:

Hi @ldionne! Thank you for taking care of this PR, I've got completely consumed by work and absolutely failed to clean up my own mess in time.

Personally, I don't think narrowing the "could it be ObjC type" condition any further via compiler intrinsics is worth it: for me (as someone who just reads libcxx source code from time to time, not a maintainer) the mere presence of ObjC-related code/comments in libcxx seems confusing enough, and I'd say that `std::make_exception_ptr<T*>` in C++ is a use-case too niche to further complicate code here, especially via something directly ObjC-related.

Nice refactoring by you, and I'm happy to see CI finally working.

LGTM

https://github.com/llvm/llvm-project/pull/135386


More information about the libcxx-commits mailing list