[libcxx-commits] [libcxx] [libc++][NFC] Remove __remove_uncvref (PR #140531)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 2 08:01:51 PDT 2025


================
@@ -125,8 +125,8 @@ class boyer_moore_searcher {
   template <class _RandomAccessIterator2>
   _LIBCPP_HIDE_FROM_ABI pair<_RandomAccessIterator2, _RandomAccessIterator2>
   operator()(_RandomAccessIterator2 __first, _RandomAccessIterator2 __last) const {
-    static_assert(__is_same_uncvref<typename iterator_traits<_RandomAccessIterator1>::value_type,
-                                    typename iterator_traits<_RandomAccessIterator2>::value_type>::value,
+    static_assert(is_same_v<typename iterator_traits<_RandomAccessIterator1>::value_type,
----------------
ldionne wrote:

Here and below, it's not clear to me that we can get rid of `remove_cvref_t`. After looking, we couldn't find a place where it says that `value_type` has to be unqualified, so I think we have to assume that it might be.

https://github.com/llvm/llvm-project/pull/140531


More information about the libcxx-commits mailing list