[libcxx-commits] [clang] [libcxxabi] [llvm] [Clang] Mangling of pack indexing type and expression for itanium (PR #123513)

[Shafik Yaghmour via libcxx-commits]

================
@@ -5828,6 +5822,15 @@ void CXXNameMangler::mangleExpression(const Expr *E, unsigned Arity,
     break;
   }
 
+  case Expr::PackIndexingExprClass: {
+    auto *PE = cast<PackIndexingExpr>(E);
+    NotPrimaryExpr();
----------------
shafik wrote:

I am looking at the test cases and I don't see the `X`, can we make sure we cover that branch in `NotPrimaryExpr` e.g. `if (AsTemplateArg && IsPrimaryExpr)`. We should make sure we cover that in the demangling as well.

https://github.com/llvm/llvm-project/pull/123513