[libcxx-commits] [libcxx] [libc++] Refactor num_get optimization to not be ABI breaking (PR #121690)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 29 08:33:27 PST 2025


================
@@ -57,8 +57,6 @@
 // because it changes the mangling of the virtual function located in the vtable, which
 // changes how it gets signed.
 #  define _LIBCPP_ABI_BAD_FUNCTION_CALL_GOOD_WHAT_MESSAGE
----------------
ldionne wrote:

Let's add a benchmark. It looks like there are some interesting ones here: https://github.com/hiraditya/std-benchmark/blob/master/cxx/stringstream.bench.cpp

Let's also add the speedup results in the PR description.

https://github.com/llvm/llvm-project/pull/121690


More information about the libcxx-commits mailing list