[libcxx-commits] [libcxx] [libcxx] Use _ftelli64/_fseeki64 on Windows (PR #123128)

[Nikolas Klauser via libcxx-commits]

Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/123128 at github.com>


================
@@ -362,6 +362,9 @@ private:
   bool __read_mode();
   void __write_mode();
 
+  _LIBCPP_HIDE_FROM_ABI static int __fseek(FILE* __file, pos_type __offset, int __whence);
+  _LIBCPP_HIDE_FROM_ABI static pos_type __ftell(FILE* __file);
----------------
philnik777 wrote:

I think we can just make these free functions. (I'd just define them at the top of the file). It would also be good to remove the `!defined(_LIBCPP_MSVCRT)` from the definition of `_LIBCPP_HAS_OFF_T_FUNCTIONS` and probably just inline `_LIBCPP_HAS_OFF_T_FUNCTIONS` as a whole, since at that point it's just equivalent do `defind(_NEWLIB_VERSION)`.

https://github.com/llvm/llvm-project/pull/123128