[libcxx-commits] [libcxx] [libcxx] Use _ftelli64/_fseeki64 on Windows (PR #123128)

[Martin Storsjö via libcxx-commits]

mstorsjo wrote:

> > > > If doing this, I guess we should do the same change in `include/__cxx03` too? Otherwise the test would fail on Windows if targeting C++03; we don't have that test config in CI though (all the C++03 tests are for other platforms), so it won't be caught.
> > > 
> > > 
> > > For now there should just be an `// UNSUPPORTED: FROZEN-CXX03-HEADERS-FIXME` in the test if it doesn't work with the frozen headers.
> > 
> > 
> > Well the test does work with the frozen headers, but we don't get the 64 bit range on Windows until we apply the same fix as here, on the frozen headers.
> 
> I meant "fails with the frozen headers".

Right, although that would also exclude the test from running in C++03 mode with frozen headers on other OSes (where it works just fine). As we don't have CI coverage for that case combination (C++03 frozen headers on Windows), I think I'd rather either just let it slip (and fix the frozen headers later) or consider adding such a test configuration.

https://github.com/llvm/llvm-project/pull/123128