[libcxx-commits] [clang] [libcxx] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

[Erich Keane via libcxx-commits]

erichkeane wrote:

> This makes me wonder how many other instances like this there are in the wild in generic code, but I guess compressed_pair-style classes aren't that ubiquitous. LGTM.

TBH, I'm actually shocked that there is only 1 Libc++ violation of this warning.  I was honestly quite positive that we'd see about a million there, plus another trillion in user code, as no one has ever really cared about this in the past.

I'm finding myself to be mildly optimistic here thanks to you guys only having 1 violation :)

Thanks for the review!

@a-tarasyuk : feel free to merge at your convenience. 

https://github.com/llvm/llvm-project/pull/121419