[libcxx-commits] [libcxx] [libc++] Implement generic associative container benchmarks (PR #123663)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 20 13:18:09 PST 2025


https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/123663

>From 280f90ec4a848be365d421171822e976b0912dec Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 17 Jan 2025 10:42:36 -0500
Subject: [PATCH 1/3] [libc++] Implement generic associative container
 benchmarks

This patch implements generic associative container benchmarks
for containers with unique keys. In doing so, it replaces the
existing std::map benchmarks which were based on the cartesian
product infrastructure and were too slow to execute.

These new benchmarks aim to strike a balance between exhaustive
coverage of all operations in the most interesting case, while
executing fairly rapidly (~40s on my machine).
---
 libcxx/test/benchmarks/GenerateInput.h        |  33 +
 .../associative_container_benchmarks.h        | 533 ++++++++++
 .../benchmarks/containers/flat_map.bench.cpp  |  25 +
 .../test/benchmarks/containers/map.bench.cpp  | 940 +-----------------
 .../test/benchmarks/containers/set.bench.cpp  |  23 +
 5 files changed, 622 insertions(+), 932 deletions(-)
 create mode 100644 libcxx/test/benchmarks/containers/associative_container_benchmarks.h
 create mode 100644 libcxx/test/benchmarks/containers/flat_map.bench.cpp
 create mode 100644 libcxx/test/benchmarks/containers/set.bench.cpp

diff --git a/libcxx/test/benchmarks/GenerateInput.h b/libcxx/test/benchmarks/GenerateInput.h
index 6d5c5167e91ed8..c87fd69162e9d4 100644
--- a/libcxx/test/benchmarks/GenerateInput.h
+++ b/libcxx/test/benchmarks/GenerateInput.h
@@ -11,6 +11,7 @@
 
 #include <algorithm>
 #include <climits>
+#include <concepts>
 #include <cstddef>
 #include <random>
 #include <string>
@@ -171,4 +172,36 @@ inline std::vector<const char*> getRandomCStringInputs(std::size_t N) {
   return cinputs;
 }
 
+template <class T>
+struct Generate {
+  // When the contents don't matter
+  static T arbitrary();
+
+  // Prefer a cheap-to-construct element if possible
+  static T cheap();
+
+  // Prefer an expensive-to-construct element if possible
+  static T expensive();
+};
+
+template <class T>
+  requires std::integral<T>
+struct Generate<T> {
+  static T arbitrary() { return 42; }
+  static T cheap() { return 42; }
+  static T expensive() { return 42; }
+  static T random() { return getRandomInteger<T>(std::numeric_limits<T>::min(), std::numeric_limits<T>::max()); }
+};
+
+template <>
+struct Generate<std::string> {
+  static std::string arbitrary() { return "hello world"; }
+  static std::string cheap() { return "small"; }
+  static std::string expensive() { return std::string(256, 'x'); }
+  static std::string random() {
+    auto length = getRandomInteger<std::size_t>(1, 1024);
+    return getRandomString(length);
+  }
+};
+
 #endif // BENCHMARK_GENERATE_INPUT_H
diff --git a/libcxx/test/benchmarks/containers/associative_container_benchmarks.h b/libcxx/test/benchmarks/containers/associative_container_benchmarks.h
new file mode 100644
index 00000000000000..0d485be74d498b
--- /dev/null
+++ b/libcxx/test/benchmarks/containers/associative_container_benchmarks.h
@@ -0,0 +1,533 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef TEST_BENCHMARKS_CONTAINERS_ASSOCIATIVE_CONTAINER_BENCHMARKS_H
+#define TEST_BENCHMARKS_CONTAINERS_ASSOCIATIVE_CONTAINER_BENCHMARKS_H
+
+#include <algorithm>
+#include <iterator>
+#include <map>
+#include <flat_map>
+#include <random>
+#include <set>
+#include <string>
+#include <vector>
+
+#include "benchmark/benchmark.h"
+#include "../GenerateInput.h"
+
+namespace support {
+
+template <class Container>
+struct adapt_operations;
+
+template <class K>
+struct adapt_operations<std::set<K>> {
+  using ValueType = typename std::set<K>::value_type;
+  using KeyType   = typename std::set<K>::key_type;
+  static ValueType value_from_key(KeyType const& k) { return k; }
+  static KeyType key_from_value(ValueType const& value) { return value; }
+};
+
+template <class K, class V>
+struct adapt_operations<std::map<K, V>> {
+  using ValueType = typename std::map<K, V>::value_type;
+  using KeyType   = typename std::map<K, V>::key_type;
+  static ValueType value_from_key(KeyType const& k) { return {k, Generate<V>::arbitrary()}; }
+  static KeyType key_from_value(ValueType const& value) { return value.first; }
+};
+
+template <class K, class V>
+struct adapt_operations<std::flat_map<K, V>> {
+  using ValueType = typename std::map<K, V>::value_type;
+  using KeyType   = typename std::map<K, V>::key_type;
+  static ValueType value_from_key(KeyType const& k) { return {k, Generate<V>::arbitrary()}; }
+  static KeyType key_from_value(ValueType const& value) { return value.first; }
+};
+
+template <class Container>
+void associative_container_benchmarks(std::string container) {
+  using Key   = typename Container::key_type;
+  using Value = typename Container::value_type;
+
+  auto generate_unique_keys = [=](std::size_t n) {
+    std::set<Key> keys;
+    while (keys.size() < n) {
+      Key k = Generate<Key>::random();
+      keys.insert(k);
+    }
+    return std::vector<Key>(keys.begin(), keys.end());
+  };
+
+  auto add_dummy_mapped_type = [](std::vector<Key> const& keys) {
+    std::vector<Value> kv;
+    for (Key const& k : keys)
+      kv.push_back(adapt_operations<Container>::value_from_key(k));
+    return kv;
+  };
+
+  auto get_key = [](Value const& v) { return adapt_operations<Container>::key_from_value(v); };
+
+  // These benchmarks are structured to perform the operation being benchmarked
+  // a small number of times at each iteration, in order to offset the cost of
+  // PauseTiming() and ResumeTiming().
+  static constexpr std::size_t BatchSize = 10;
+
+  struct ScratchSpace {
+    char storage[sizeof(Container)];
+  };
+
+  /////////////////////////
+  // Constructors
+  /////////////////////////
+  benchmark::RegisterBenchmark(container + "::ctor(const&)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Container src(in.begin(), in.end());
+    ScratchSpace c[BatchSize];
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        new (c + i) Container(src);
+        benchmark::DoNotOptimize(c + i);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        reinterpret_cast<Container*>(c + i)->~Container();
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::ctor(iterator, iterator) (unsorted sequence)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::mt19937 randomness;
+    std::vector<Key> keys = generate_unique_keys(size);
+    std::shuffle(keys.begin(), keys.end(), randomness);
+    std::vector<Value> in = add_dummy_mapped_type(keys);
+    ScratchSpace c[BatchSize];
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        new (c + i) Container(in.begin(), in.end());
+        benchmark::DoNotOptimize(c + i);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        reinterpret_cast<Container*>(c + i)->~Container();
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::ctor(iterator, iterator) (sorted sequence)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Key> keys  = generate_unique_keys(size);
+    std::sort(keys.begin(), keys.end());
+    std::vector<Value> in = add_dummy_mapped_type(keys);
+    ScratchSpace c[BatchSize];
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        new (c + i) Container(in.begin(), in.end());
+        benchmark::DoNotOptimize(c + i);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        reinterpret_cast<Container*>(c + i)->~Container();
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  /////////////////////////
+  // Assignment
+  /////////////////////////
+  benchmark::RegisterBenchmark(container + "::operator=(const&)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Container src(in.begin(), in.end());
+    Container c[BatchSize];
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i] = src;
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].clear();
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  /////////////////////////
+  // Insertion
+  /////////////////////////
+  benchmark::RegisterBenchmark(container + "::insert(value) (already present)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Value to_insert        = in[in.size() / 2]; // pick any existing value
+    std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].insert(to_insert);
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      // There is no cleanup to do, since associative containers don't insert
+      // if the key is already present.
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::insert(value) (new value)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + 1));
+    Value to_insert        = in.back();
+    in.pop_back();
+    std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].insert(to_insert);
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].erase(get_key(to_insert));
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::insert(hint, value) (good hint)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + 1));
+    Value to_insert        = in.back();
+    in.pop_back();
+
+    std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
+    typename Container::iterator hints[BatchSize];
+    for (int i = 0; i != BatchSize; ++i) {
+      hints[i] = c[i].lower_bound(get_key(to_insert));
+    }
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].insert(hints[i], to_insert);
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].erase(get_key(to_insert));
+        hints[i] = c[i].lower_bound(get_key(to_insert)); // refresh hints in case of invalidation
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::insert(hint, value) (bad hint)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + 1));
+    Value to_insert        = in.back();
+    in.pop_back();
+    std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].insert(c[i].begin(), to_insert);
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].erase(get_key(to_insert));
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::insert(iterator, iterator) (all new keys)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + (size / 10)));
+
+    // Populate a container with a small number of elements, that's what containers will start with.
+    std::vector<Value> small;
+    for (int i = 0; i != (size / 10); ++i) {
+      small.push_back(in.back());
+      in.pop_back();
+    }
+    Container c(small.begin(), small.end());
+
+    for (auto _ : st) {
+      c.insert(in.begin(), in.end());
+      benchmark::DoNotOptimize(c);
+      benchmark::ClobberMemory();
+
+      st.PauseTiming();
+      c = Container(small.begin(), small.end());
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::insert(iterator, iterator) (half new keys)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+
+    // Populate a container that already contains half the elements we'll try inserting,
+    // that's what our container will start with.
+    std::vector<Value> small;
+    for (int i = 0; i != size / 2; ++i) {
+      small.push_back(in.at(i * 2));
+    }
+    Container c(small.begin(), small.end());
+
+    for (auto _ : st) {
+      c.insert(in.begin(), in.end());
+      benchmark::DoNotOptimize(c);
+      benchmark::ClobberMemory();
+
+      st.PauseTiming();
+      c = Container(small.begin(), small.end());
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  /////////////////////////
+  // Erasure
+  /////////////////////////
+  benchmark::RegisterBenchmark(container + "::erase(key) (existent)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Value element          = in[in.size() / 2]; // pick any element
+    std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].erase(get_key(element));
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].insert(element);
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::erase(key) (non-existent)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + 1));
+    Value element          = in.back();
+    in.pop_back();
+    Container c(in.begin(), in.end());
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c.erase(get_key(element));
+        benchmark::DoNotOptimize(c);
+        benchmark::ClobberMemory();
+      }
+
+      // no cleanup required because we erased a non-existent element
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::erase(iterator)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Value element          = in[in.size() / 2]; // pick any element
+
+    std::vector<Container> c;
+    std::vector<typename Container::iterator> iterators;
+    for (int i = 0; i != BatchSize; ++i) {
+      c.push_back(Container(in.begin(), in.end()));
+      iterators.push_back(c[i].find(get_key(element)));
+    }
+
+    while (st.KeepRunningBatch(BatchSize)) {
+      for (int i = 0; i != BatchSize; ++i) {
+        c[i].erase(iterators[i]);
+        benchmark::DoNotOptimize(c[i]);
+        benchmark::ClobberMemory();
+      }
+
+      st.PauseTiming();
+      for (int i = 0; i != BatchSize; ++i) {
+        iterators[i] = c[i].insert(element).first;
+      }
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::erase(iterator, iterator) (erase half the container)", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Container c(in.begin(), in.end());
+
+    auto first = std::next(c.begin(), c.size() / 4);
+    auto last  = std::next(c.begin(), 3 * (c.size() / 4));
+    for (auto _ : st) {
+      c.erase(first, last);
+      benchmark::DoNotOptimize(c);
+      benchmark::ClobberMemory();
+
+      st.PauseTiming();
+      c     = Container(in.begin(), in.end());
+      first = std::next(c.begin(), c.size() / 4);
+      last  = std::next(c.begin(), 3 * (c.size() / 4));
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  benchmark::RegisterBenchmark(container + "::clear()", [=](auto& st) {
+    const std::size_t size = st.range(0);
+    std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+    Container c(in.begin(), in.end());
+
+    for (auto _ : st) {
+      c.clear();
+      benchmark::DoNotOptimize(c);
+      benchmark::ClobberMemory();
+
+      st.PauseTiming();
+      c = Container(in.begin(), in.end());
+      st.ResumeTiming();
+    }
+  })->Arg(1024);
+
+  /////////////////////////
+  // Query
+  /////////////////////////
+  auto bench_with_existent_key = [=](auto func) {
+    return [=](auto& st) {
+      const std::size_t size = st.range(0);
+      std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size));
+      Value element          = in[in.size() / 2]; // pick any element
+      Container c(in.begin(), in.end());
+
+      while (st.KeepRunningBatch(BatchSize)) {
+        for (int i = 0; i != BatchSize; ++i) {
+          auto result = func(c, element);
+          benchmark::DoNotOptimize(c);
+          benchmark::DoNotOptimize(result);
+          benchmark::ClobberMemory();
+        }
+      }
+    };
+  };
+
+  auto bench_with_nonexistent_key = [=](auto func) {
+    return [=](auto& st) {
+      const std::size_t size = st.range(0);
+      std::vector<Value> in  = add_dummy_mapped_type(generate_unique_keys(size + 1));
+      Value element          = in.back();
+      in.pop_back();
+      Container c(in.begin(), in.end());
+
+      while (st.KeepRunningBatch(BatchSize)) {
+        for (int i = 0; i != BatchSize; ++i) {
+          auto result = func(c, element);
+          benchmark::DoNotOptimize(c);
+          benchmark::DoNotOptimize(result);
+          benchmark::ClobberMemory();
+        }
+      }
+    };
+  };
+
+  benchmark::RegisterBenchmark(
+      container + "::find(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) { return c.find(get_key(element)); }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::find(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) { return c.find(get_key(element)); }))
+      ->Arg(1024);
+
+  benchmark::RegisterBenchmark(
+      container + "::count(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) { return c.count(get_key(element)); }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::count(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) { return c.count(get_key(element)); }))
+      ->Arg(1024);
+
+  benchmark::RegisterBenchmark(
+      container + "::contains(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) { return c.contains(get_key(element)); }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::contains(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) {
+        return c.contains(get_key(element));
+      }))
+      ->Arg(1024);
+
+  benchmark::RegisterBenchmark(
+      container + "::lower_bound(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) {
+        return c.lower_bound(get_key(element));
+      }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::lower_bound(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) {
+        return c.lower_bound(get_key(element));
+      }))
+      ->Arg(1024);
+
+  benchmark::RegisterBenchmark(
+      container + "::upper_bound(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) {
+        return c.upper_bound(get_key(element));
+      }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::upper_bound(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) {
+        return c.upper_bound(get_key(element));
+      }))
+      ->Arg(1024);
+
+  benchmark::RegisterBenchmark(
+      container + "::equal_range(key) (existent)",
+      bench_with_existent_key([=](Container const& c, Value const& element) {
+        return c.equal_range(get_key(element));
+      }))
+      ->Arg(1024);
+  benchmark::RegisterBenchmark(
+      container + "::equal_range(key) (non-existent)",
+      bench_with_nonexistent_key([=](Container const& c, Value const& element) {
+        return c.equal_range(get_key(element));
+      }))
+      ->Arg(1024);
+}
+
+} // namespace support
+
+#endif // TEST_BENCHMARKS_CONTAINERS_ASSOCIATIVE_CONTAINER_BENCHMARKS_H
diff --git a/libcxx/test/benchmarks/containers/flat_map.bench.cpp b/libcxx/test/benchmarks/containers/flat_map.bench.cpp
new file mode 100644
index 00000000000000..02e0b31ee5f4db
--- /dev/null
+++ b/libcxx/test/benchmarks/containers/flat_map.bench.cpp
@@ -0,0 +1,25 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+#include <flat_map>
+#include <string>
+
+#include "associative_container_benchmarks.h"
+#include "benchmark/benchmark.h"
+
+int main(int argc, char** argv) {
+  support::associative_container_benchmarks<std::flat_map<int, int>>("std::flat_map<int, int>");
+  // support::associative_container_benchmarks<std::map<std::string, int>>("std::map<std::string, int>");
+
+  benchmark::Initialize(&argc, argv);
+  benchmark::RunSpecifiedBenchmarks();
+  benchmark::Shutdown();
+  return 0;
+}
diff --git a/libcxx/test/benchmarks/containers/map.bench.cpp b/libcxx/test/benchmarks/containers/map.bench.cpp
index e37c7d8d551635..5c5ba7cc9d3db0 100644
--- a/libcxx/test/benchmarks/containers/map.bench.cpp
+++ b/libcxx/test/benchmarks/containers/map.bench.cpp
@@ -6,944 +6,20 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14
+// UNSUPPORTED: c++03, c++11, c++14, c++17
 
-#include <algorithm>
-#include <cstdint>
 #include <map>
-#include <random>
-#include <vector>
+#include <string>
 
-#include "../CartesianBenchmarks.h"
+#include "associative_container_benchmarks.h"
 #include "benchmark/benchmark.h"
-#include "test_macros.h"
-
-// When VALIDATE is defined the benchmark will run to validate the benchmarks.
-// The time taken by several operations depend on whether or not an element
-// exists. To avoid errors in the benchmark these operations have a validation
-// mode to test the benchmark. Since they are not meant to be benchmarked the
-// number of sizes tested is limited to 1.
-// #define VALIDATE
-
-namespace {
-
-enum class Mode { Hit, Miss };
-
-struct AllModes : EnumValuesAsTuple<AllModes, Mode, 2> {
-  static constexpr const char* Names[] = {"ExistingElement", "NewElement"};
-};
-
-// The positions of the hints to pick:
-// - Begin picks the first item. The item cannot be put before this element.
-// - Thrid picks the third item. This is just an element with a valid entry
-//   before and after it.
-// - Correct contains the correct hint.
-// - End contains a hint to the end of the map.
-enum class Hint { Begin, Third, Correct, End };
-struct AllHints : EnumValuesAsTuple<AllHints, Hint, 4> {
-  static constexpr const char* Names[] = {"Begin", "Third", "Correct", "End"};
-};
-
-enum class Order { Sorted, Random };
-struct AllOrders : EnumValuesAsTuple<AllOrders, Order, 2> {
-  static constexpr const char* Names[] = {"Sorted", "Random"};
-};
-
-struct TestSets {
-  std::vector<uint64_t> Keys;
-  std::vector<std::map<uint64_t, int64_t> > Maps;
-  std::vector<std::vector<typename std::map<uint64_t, int64_t>::const_iterator> > Hints;
-};
-
-enum class Shuffle { None, Keys, Hints };
-
-TestSets makeTestingSets(size_t MapSize, Mode mode, Shuffle shuffle, size_t max_maps) {
-  /*
-   * The shuffle does not retain the random number generator to use the same
-   * set of random numbers for every iteration.
-   */
-  TestSets R;
-
-  int MapCount = std::min(max_maps, 1000000 / MapSize);
-
-  for (uint64_t I = 0; I < MapSize; ++I) {
-    R.Keys.push_back(mode == Mode::Hit ? 2 * I + 2 : 2 * I + 1);
-  }
-  if (shuffle == Shuffle::Keys)
-    std::shuffle(R.Keys.begin(), R.Keys.end(), std::mt19937());
-
-  for (int M = 0; M < MapCount; ++M) {
-    auto& map   = R.Maps.emplace_back();
-    auto& hints = R.Hints.emplace_back();
-    for (uint64_t I = 0; I < MapSize; ++I) {
-      hints.push_back(map.insert(std::make_pair(2 * I + 2, 0)).first);
-    }
-    if (shuffle == Shuffle::Hints)
-      std::shuffle(hints.begin(), hints.end(), std::mt19937());
-  }
-
-  return R;
-}
-
-struct Base {
-  size_t MapSize;
-  Base(size_t T) : MapSize(T) {}
-
-  std::string baseName() const { return "_MapSize=" + std::to_string(MapSize); }
-};
-
-//*******************************************************************|
-//                       Member functions                            |
-//*******************************************************************|
-
-struct ConstructorDefault {
-  void run(benchmark::State& State) const {
-    for (auto _ : State) {
-      benchmark::DoNotOptimize(std::map<uint64_t, int64_t>());
-    }
-  }
-
-  std::string name() const { return "BM_ConstructorDefault"; }
-};
-
-struct ConstructorIterator : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-#ifndef VALIDATE
-      benchmark::DoNotOptimize(std::map<uint64_t, int64_t>(Map.begin(), Map.end()));
-#else
-      std::map<uint64_t, int64_t> M{Map.begin(), Map.end()};
-      if (M != Map)
-        State.SkipWithError("Map copy not identical");
-#endif
-    }
-  }
-
-  std::string name() const { return "BM_ConstructorIterator" + baseName(); }
-};
-
-struct ConstructorCopy : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-#ifndef VALIDATE
-      std::map<uint64_t, int64_t> M(Map);
-      benchmark::DoNotOptimize(M);
-#else
-      std::map<uint64_t, int64_t> M(Map);
-      if (M != Map)
-        State.SkipWithError("Map copy not identical");
-#endif
-    }
-  }
-
-  std::string name() const { return "BM_ConstructorCopy" + baseName(); }
-};
-
-struct ConstructorMove : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        std::map<uint64_t, int64_t> M(std::move(Map));
-        benchmark::DoNotOptimize(M);
-      }
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_ConstructorMove" + baseName(); }
-};
-
-//*******************************************************************|
-//                           Capacity                                |
-//*******************************************************************|
-
-struct Empty : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    for (auto _ : State) {
-#ifndef VALIDATE
-      benchmark::DoNotOptimize(Map.empty());
-#else
-      if (Map.empty())
-        State.SkipWithError("Map contains an invalid number of elements.");
-#endif
-    }
-  }
-
-  std::string name() const { return "BM_Empty" + baseName(); }
-};
-
-struct Size : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    for (auto _ : State) {
-#ifndef VALIDATE
-      benchmark::DoNotOptimize(Map.size());
-#else
-      if (Map.size() != MapSize)
-        State.SkipWithError("Map contains an invalid number of elements.");
-#endif
-    }
-  }
-
-  std::string name() const { return "BM_Size" + baseName(); }
-};
-
-//*******************************************************************|
-//                           Modifiers                               |
-//*******************************************************************|
-
-struct Clear : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        Map.clear();
-        benchmark::DoNotOptimize(Map);
-      }
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_Clear" + baseName(); }
-};
-
-template <class Mode, class Order>
-struct Insert : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert(std::make_pair(K, 1)));
-#else
-          bool Inserted = Map.insert(std::make_pair(K, 1)).second;
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted)
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (!Inserted)
-              State.SkipWithError("Failed to insert e new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_Insert" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Hint>
-struct InsertHint : Base {
-  using Base::Base;
-
-  template < ::Hint hint>
-  typename std::enable_if<hint == ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map = Data.Maps[I];
-        auto H    = Data.Hints[I].begin();
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert(*H, std::make_pair(K, 1)));
-#else
-          auto Inserted = Map.insert(*H, std::make_pair(K, 1));
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted != *H)
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (++Inserted != *H)
-              State.SkipWithError("Failed to insert a new element");
-          }
-#endif
-          ++H;
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  template < ::Hint hint>
-  typename std::enable_if<hint != ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map  = Data.Maps[I];
-        auto Third = *(Data.Hints[I].begin() + 2);
-        for (auto K : Data.Keys) {
-          auto Itor = hint == ::Hint::Begin ? Map.begin() : hint == ::Hint::Third ? Third : Map.end();
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert(Itor, std::make_pair(K, 1)));
-#else
-          size_t Size = Map.size();
-          Map.insert(Itor, std::make_pair(K, 1));
-          if (Mode() == ::Mode::Hit) {
-            if (Size != Map.size())
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (Size + 1 != Map.size())
-              State.SkipWithError("Failed to insert a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  void run(benchmark::State& State) const {
-    static constexpr auto h = Hint();
-    run<h>(State);
-  }
-
-  std::string name() const { return "BM_InsertHint" + baseName() + Mode::name() + Hint::name(); }
-};
-
-template <class Mode, class Order>
-struct InsertAssign : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert_or_assign(K, 1));
-#else
-          bool Inserted = Map.insert_or_assign(K, 1).second;
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted)
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (!Inserted)
-              State.SkipWithError("Failed to insert e new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_InsertAssign" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Hint>
-struct InsertAssignHint : Base {
-  using Base::Base;
-
-  template < ::Hint hint>
-  typename std::enable_if<hint == ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map = Data.Maps[I];
-        auto H    = Data.Hints[I].begin();
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert_or_assign(*H, K, 1));
-#else
-          auto Inserted = Map.insert_or_assign(*H, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted != *H)
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (++Inserted != *H)
-              State.SkipWithError("Failed to insert a new element");
-          }
-#endif
-          ++H;
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  template < ::Hint hint>
-  typename std::enable_if<hint != ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map  = Data.Maps[I];
-        auto Third = *(Data.Hints[I].begin() + 2);
-        for (auto K : Data.Keys) {
-          auto Itor = hint == ::Hint::Begin ? Map.begin() : hint == ::Hint::Third ? Third : Map.end();
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.insert_or_assign(Itor, K, 1));
-#else
-          size_t Size = Map.size();
-          Map.insert_or_assign(Itor, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Size != Map.size())
-              State.SkipWithError("Inserted a duplicate element");
-          } else {
-            if (Size + 1 != Map.size())
-              State.SkipWithError("Failed to insert a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  void run(benchmark::State& State) const {
-    static constexpr auto h = Hint();
-    run<h>(State);
-  }
-
-  std::string name() const { return "BM_InsertAssignHint" + baseName() + Mode::name() + Hint::name(); }
-};
-
-template <class Mode, class Order>
-struct Emplace : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.emplace(K, 1));
-#else
-          bool Inserted = Map.emplace(K, 1).second;
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted)
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (!Inserted)
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_Emplace" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Hint>
-struct EmplaceHint : Base {
-  using Base::Base;
-
-  template < ::Hint hint>
-  typename std::enable_if<hint == ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map = Data.Maps[I];
-        auto H    = Data.Hints[I].begin();
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.emplace_hint(*H, K, 1));
-#else
-          auto Inserted = Map.emplace_hint(*H, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted != *H)
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (++Inserted != *H)
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-          ++H;
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  template < ::Hint hint>
-  typename std::enable_if<hint != ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map  = Data.Maps[I];
-        auto Third = *(Data.Hints[I].begin() + 2);
-        for (auto K : Data.Keys) {
-          auto Itor = hint == ::Hint::Begin ? Map.begin() : hint == ::Hint::Third ? Third : Map.end();
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.emplace_hint(Itor, K, 1));
-#else
-          size_t Size = Map.size();
-          Map.emplace_hint(Itor, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Size != Map.size())
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (Size + 1 != Map.size())
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  void run(benchmark::State& State) const {
-    static constexpr auto h = Hint();
-    run<h>(State);
-  }
-
-  std::string name() const { return "BM_EmplaceHint" + baseName() + Mode::name() + Hint::name(); }
-};
-
-template <class Mode, class Order>
-struct TryEmplace : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.try_emplace(K, 1));
-#else
-          bool Inserted = Map.try_emplace(K, 1).second;
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted)
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (!Inserted)
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_TryEmplace" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Hint>
-struct TryEmplaceHint : Base {
-  using Base::Base;
-
-  template < ::Hint hint>
-  typename std::enable_if<hint == ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map = Data.Maps[I];
-        auto H    = Data.Hints[I].begin();
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.try_emplace(*H, K, 1));
-#else
-          auto Inserted = Map.try_emplace(*H, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Inserted != *H)
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (++Inserted != *H)
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-          ++H;
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  template < ::Hint hint>
-  typename std::enable_if<hint != ::Hint::Correct>::type run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map  = Data.Maps[I];
-        auto Third = *(Data.Hints[I].begin() + 2);
-        for (auto K : Data.Keys) {
-          auto Itor = hint == ::Hint::Begin ? Map.begin() : hint == ::Hint::Third ? Third : Map.end();
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.try_emplace(Itor, K, 1));
-#else
-          size_t Size = Map.size();
-          Map.try_emplace(Itor, K, 1);
-          if (Mode() == ::Mode::Hit) {
-            if (Size != Map.size())
-              State.SkipWithError("Emplaced a duplicate element");
-          } else {
-            if (Size + 1 != Map.size())
-              State.SkipWithError("Failed to emplace a new element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  void run(benchmark::State& State) const {
-    static constexpr auto h = Hint();
-    run<h>(State);
-  }
-
-  std::string name() const { return "BM_TryEmplaceHint" + baseName() + Mode::name() + Hint::name(); }
-};
-
-template <class Mode, class Order>
-struct Erase : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-        for (auto K : Data.Keys) {
-#ifndef VALIDATE
-          benchmark::DoNotOptimize(Map.erase(K));
-#else
-          size_t I = Map.erase(K);
-          if (Mode() == ::Mode::Hit) {
-            if (I == 0)
-              State.SkipWithError("Did not find the existing element");
-          } else {
-            if (I == 1)
-              State.SkipWithError("Did find the non-existing element");
-          }
-#endif
-        }
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_Erase" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Order>
-struct EraseIterator : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data =
-        makeTestingSets(MapSize, Mode::Hit, Order::value == ::Order::Random ? Shuffle::Hints : Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (size_t I = 0; I < Data.Maps.size(); ++I) {
-        auto& Map = Data.Maps[I];
-        for (auto H : Data.Hints[I]) {
-          benchmark::DoNotOptimize(Map.erase(H));
-        }
-#ifdef VALIDATE
-        if (!Map.empty())
-          State.SkipWithError("Did not erase the entire map");
-#endif
-      }
-
-      State.PauseTiming();
-      Data =
-          makeTestingSets(MapSize, Mode::Hit, Order::value == ::Order::Random ? Shuffle::Hints : Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_EraseIterator" + baseName() + Order::name(); }
-};
-
-struct EraseRange : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-    while (State.KeepRunningBatch(MapSize * Data.Maps.size())) {
-      for (auto& Map : Data.Maps) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.erase(Map.begin(), Map.end()));
-#else
-        Map.erase(Map.begin(), Map.end());
-        if (!Map.empty())
-          State.SkipWithError("Did not erase the entire map");
-#endif
-      }
-
-      State.PauseTiming();
-      Data = makeTestingSets(MapSize, Mode::Hit, Shuffle::None, 1000);
-      State.ResumeTiming();
-    }
-  }
-
-  std::string name() const { return "BM_EraseRange" + baseName(); }
-};
-
-//*******************************************************************|
-//                            Lookup                                 |
-//*******************************************************************|
-
-template <class Mode, class Order>
-struct Count : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-      for (auto K : Data.Keys) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.count(K));
-#else
-        size_t I = Map.count(K);
-        if (Mode() == ::Mode::Hit) {
-          if (I == 0)
-            State.SkipWithError("Did not find the existing element");
-        } else {
-          if (I == 1)
-            State.SkipWithError("Did find the non-existing element");
-        }
-#endif
-      }
-    }
-  }
-
-  std::string name() const { return "BM_Count" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Order>
-struct Find : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-      for (auto K : Data.Keys) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.find(K));
-#else
-        auto Itor = Map.find(K);
-        if (Mode() == ::Mode::Hit) {
-          if (Itor == Map.end())
-            State.SkipWithError("Did not find the existing element");
-        } else {
-          if (Itor != Map.end())
-            State.SkipWithError("Did find the non-existing element");
-        }
-#endif
-      }
-    }
-  }
-
-  std::string name() const { return "BM_Find" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Order>
-struct EqualRange : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-      for (auto K : Data.Keys) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.equal_range(K));
-#else
-        auto Range = Map.equal_range(K);
-        if (Mode() == ::Mode::Hit) {
-          // Adjust validation for the last element.
-          auto Key = K;
-          if (Range.second == Map.end() && K == 2 * MapSize) {
-            --Range.second;
-            Key -= 2;
-          }
-          if (Range.first == Map.end() || Range.first->first != K || Range.second == Map.end() ||
-              Range.second->first - 2 != Key)
-            State.SkipWithError("Did not find the existing element");
-        } else {
-          if (Range.first == Map.end() || Range.first->first - 1 != K || Range.second == Map.end() ||
-              Range.second->first - 1 != K)
-            State.SkipWithError("Did find the non-existing element");
-        }
-#endif
-      }
-    }
-  }
-
-  std::string name() const { return "BM_EqualRange" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Order>
-struct LowerBound : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-      for (auto K : Data.Keys) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.lower_bound(K));
-#else
-        auto Itor = Map.lower_bound(K);
-        if (Mode() == ::Mode::Hit) {
-          if (Itor == Map.end() || Itor->first != K)
-            State.SkipWithError("Did not find the existing element");
-        } else {
-          if (Itor == Map.end() || Itor->first - 1 != K)
-            State.SkipWithError("Did find the non-existing element");
-        }
-#endif
-      }
-    }
-  }
-
-  std::string name() const { return "BM_LowerBound" + baseName() + Mode::name() + Order::name(); }
-};
-
-template <class Mode, class Order>
-struct UpperBound : Base {
-  using Base::Base;
-
-  void run(benchmark::State& State) const {
-    auto Data = makeTestingSets(MapSize, Mode(), Order::value == ::Order::Random ? Shuffle::Keys : Shuffle::None, 1);
-    auto& Map = Data.Maps.front();
-    while (State.KeepRunningBatch(MapSize)) {
-      for (auto K : Data.Keys) {
-#ifndef VALIDATE
-        benchmark::DoNotOptimize(Map.upper_bound(K));
-#else
-        std::map<uint64_t, int64_t>::iterator Itor = Map.upper_bound(K);
-        if (Mode() == ::Mode::Hit) {
-          // Adjust validation for the last element.
-          auto Key = K;
-          if (Itor == Map.end() && K == 2 * MapSize) {
-            --Itor;
-            Key -= 2;
-          }
-          if (Itor == Map.end() || Itor->first - 2 != Key)
-            State.SkipWithError("Did not find the existing element");
-        } else {
-          if (Itor == Map.end() || Itor->first - 1 != K)
-            State.SkipWithError("Did find the non-existing element");
-        }
-#endif
-      }
-    }
-  }
-
-  std::string name() const { return "BM_UpperBound" + baseName() + Mode::name() + Order::name(); }
-};
-
-} // namespace
 
 int main(int argc, char** argv) {
-  benchmark::Initialize(&argc, argv);
-  if (benchmark::ReportUnrecognizedArguments(argc, argv))
-    return 1;
-
-#ifdef VALIDATE
-  const std::vector<size_t> MapSize{10};
-#else
-  const std::vector<size_t> MapSize{10, 100, 1000, 10000, 100000, 1000000};
-#endif
-
-  // Member functions
-  makeCartesianProductBenchmark<ConstructorDefault>();
-  makeCartesianProductBenchmark<ConstructorIterator>(MapSize);
-  makeCartesianProductBenchmark<ConstructorCopy>(MapSize);
-  makeCartesianProductBenchmark<ConstructorMove>(MapSize);
-
-  // Capacity
-  makeCartesianProductBenchmark<Empty>(MapSize);
-  makeCartesianProductBenchmark<Size>(MapSize);
-
-  // Modifiers
-  makeCartesianProductBenchmark<Clear>(MapSize);
-  makeCartesianProductBenchmark<Insert, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<InsertHint, AllModes, AllHints>(MapSize);
-  makeCartesianProductBenchmark<InsertAssign, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<InsertAssignHint, AllModes, AllHints>(MapSize);
-
-  makeCartesianProductBenchmark<Emplace, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<EmplaceHint, AllModes, AllHints>(MapSize);
-  makeCartesianProductBenchmark<TryEmplace, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<TryEmplaceHint, AllModes, AllHints>(MapSize);
-  makeCartesianProductBenchmark<Erase, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<EraseIterator, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<EraseRange>(MapSize);
-
-  // Lookup
-  makeCartesianProductBenchmark<Count, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<Find, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<EqualRange, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<LowerBound, AllModes, AllOrders>(MapSize);
-  makeCartesianProductBenchmark<UpperBound, AllModes, AllOrders>(MapSize);
+  support::associative_container_benchmarks<std::map<int, int>>("std::map<int, int>");
+  support::associative_container_benchmarks<std::map<std::string, int>>("std::map<std::string, int>");
 
+  benchmark::Initialize(&argc, argv);
   benchmark::RunSpecifiedBenchmarks();
+  benchmark::Shutdown();
+  return 0;
 }
diff --git a/libcxx/test/benchmarks/containers/set.bench.cpp b/libcxx/test/benchmarks/containers/set.bench.cpp
new file mode 100644
index 00000000000000..6a8de0862f2ae3
--- /dev/null
+++ b/libcxx/test/benchmarks/containers/set.bench.cpp
@@ -0,0 +1,23 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+#include <set>
+
+#include "associative_container_benchmarks.h"
+#include "benchmark/benchmark.h"
+
+int main(int argc, char** argv) {
+  support::associative_container_benchmarks<std::set<int>>("std::set<int>");
+
+  benchmark::Initialize(&argc, argv);
+  benchmark::RunSpecifiedBenchmarks();
+  benchmark::Shutdown();
+  return 0;
+}

>From 2e82b41dbaaffd14381c56122fc043221b85bb31 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 20 Jan 2025 14:24:54 -0500
Subject: [PATCH 2/3] Fix leftover comment

---
 libcxx/test/benchmarks/containers/flat_map.bench.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/test/benchmarks/containers/flat_map.bench.cpp b/libcxx/test/benchmarks/containers/flat_map.bench.cpp
index 02e0b31ee5f4db..dd600c7b10d5e1 100644
--- a/libcxx/test/benchmarks/containers/flat_map.bench.cpp
+++ b/libcxx/test/benchmarks/containers/flat_map.bench.cpp
@@ -16,7 +16,7 @@
 
 int main(int argc, char** argv) {
   support::associative_container_benchmarks<std::flat_map<int, int>>("std::flat_map<int, int>");
-  // support::associative_container_benchmarks<std::map<std::string, int>>("std::map<std::string, int>");
+  support::associative_container_benchmarks<std::flat_map<std::string, int>>("std::flat_map<std::string, int>");
 
   benchmark::Initialize(&argc, argv);
   benchmark::RunSpecifiedBenchmarks();

>From 045fb6022267f17c7dce54d4926aa881bc198dcb Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 20 Jan 2025 16:17:58 -0500
Subject: [PATCH 3/3] Fix -Wsign-compare

---
 .../associative_container_benchmarks.h        | 52 +++++++++----------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/libcxx/test/benchmarks/containers/associative_container_benchmarks.h b/libcxx/test/benchmarks/containers/associative_container_benchmarks.h
index 0d485be74d498b..05b82ee9992f4d 100644
--- a/libcxx/test/benchmarks/containers/associative_container_benchmarks.h
+++ b/libcxx/test/benchmarks/containers/associative_container_benchmarks.h
@@ -92,14 +92,14 @@ void associative_container_benchmarks(std::string container) {
     ScratchSpace c[BatchSize];
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         new (c + i) Container(src);
         benchmark::DoNotOptimize(c + i);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         reinterpret_cast<Container*>(c + i)->~Container();
       }
       st.ResumeTiming();
@@ -115,14 +115,14 @@ void associative_container_benchmarks(std::string container) {
     ScratchSpace c[BatchSize];
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         new (c + i) Container(in.begin(), in.end());
         benchmark::DoNotOptimize(c + i);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         reinterpret_cast<Container*>(c + i)->~Container();
       }
       st.ResumeTiming();
@@ -137,14 +137,14 @@ void associative_container_benchmarks(std::string container) {
     ScratchSpace c[BatchSize];
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         new (c + i) Container(in.begin(), in.end());
         benchmark::DoNotOptimize(c + i);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         reinterpret_cast<Container*>(c + i)->~Container();
       }
       st.ResumeTiming();
@@ -161,14 +161,14 @@ void associative_container_benchmarks(std::string container) {
     Container c[BatchSize];
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i] = src;
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].clear();
       }
       st.ResumeTiming();
@@ -185,7 +185,7 @@ void associative_container_benchmarks(std::string container) {
     std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].insert(to_insert);
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
@@ -204,14 +204,14 @@ void associative_container_benchmarks(std::string container) {
     std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].insert(to_insert);
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].erase(get_key(to_insert));
       }
       st.ResumeTiming();
@@ -226,19 +226,19 @@ void associative_container_benchmarks(std::string container) {
 
     std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
     typename Container::iterator hints[BatchSize];
-    for (int i = 0; i != BatchSize; ++i) {
+    for (std::size_t i = 0; i != BatchSize; ++i) {
       hints[i] = c[i].lower_bound(get_key(to_insert));
     }
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].insert(hints[i], to_insert);
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].erase(get_key(to_insert));
         hints[i] = c[i].lower_bound(get_key(to_insert)); // refresh hints in case of invalidation
       }
@@ -254,14 +254,14 @@ void associative_container_benchmarks(std::string container) {
     std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].insert(c[i].begin(), to_insert);
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].erase(get_key(to_insert));
       }
       st.ResumeTiming();
@@ -274,7 +274,7 @@ void associative_container_benchmarks(std::string container) {
 
     // Populate a container with a small number of elements, that's what containers will start with.
     std::vector<Value> small;
-    for (int i = 0; i != (size / 10); ++i) {
+    for (std::size_t i = 0; i != (size / 10); ++i) {
       small.push_back(in.back());
       in.pop_back();
     }
@@ -298,7 +298,7 @@ void associative_container_benchmarks(std::string container) {
     // Populate a container that already contains half the elements we'll try inserting,
     // that's what our container will start with.
     std::vector<Value> small;
-    for (int i = 0; i != size / 2; ++i) {
+    for (std::size_t i = 0; i != size / 2; ++i) {
       small.push_back(in.at(i * 2));
     }
     Container c(small.begin(), small.end());
@@ -324,14 +324,14 @@ void associative_container_benchmarks(std::string container) {
     std::vector<Container> c(BatchSize, Container(in.begin(), in.end()));
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].erase(get_key(element));
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].insert(element);
       }
       st.ResumeTiming();
@@ -346,7 +346,7 @@ void associative_container_benchmarks(std::string container) {
     Container c(in.begin(), in.end());
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c.erase(get_key(element));
         benchmark::DoNotOptimize(c);
         benchmark::ClobberMemory();
@@ -363,20 +363,20 @@ void associative_container_benchmarks(std::string container) {
 
     std::vector<Container> c;
     std::vector<typename Container::iterator> iterators;
-    for (int i = 0; i != BatchSize; ++i) {
+    for (std::size_t i = 0; i != BatchSize; ++i) {
       c.push_back(Container(in.begin(), in.end()));
       iterators.push_back(c[i].find(get_key(element)));
     }
 
     while (st.KeepRunningBatch(BatchSize)) {
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         c[i].erase(iterators[i]);
         benchmark::DoNotOptimize(c[i]);
         benchmark::ClobberMemory();
       }
 
       st.PauseTiming();
-      for (int i = 0; i != BatchSize; ++i) {
+      for (std::size_t i = 0; i != BatchSize; ++i) {
         iterators[i] = c[i].insert(element).first;
       }
       st.ResumeTiming();
@@ -430,7 +430,7 @@ void associative_container_benchmarks(std::string container) {
       Container c(in.begin(), in.end());
 
       while (st.KeepRunningBatch(BatchSize)) {
-        for (int i = 0; i != BatchSize; ++i) {
+        for (std::size_t i = 0; i != BatchSize; ++i) {
           auto result = func(c, element);
           benchmark::DoNotOptimize(c);
           benchmark::DoNotOptimize(result);
@@ -449,7 +449,7 @@ void associative_container_benchmarks(std::string container) {
       Container c(in.begin(), in.end());
 
       while (st.KeepRunningBatch(BatchSize)) {
-        for (int i = 0; i != BatchSize; ++i) {
+        for (std::size_t i = 0; i != BatchSize; ++i) {
           auto result = func(c, element);
           benchmark::DoNotOptimize(c);
           benchmark::DoNotOptimize(result);



More information about the libcxx-commits mailing list