[libcxx-commits] [libcxx] [WIP] [libcxx] PR testrun (ignore) (PR #123570)

[Martin Storsjö via libcxx-commits]

https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/123570

Ignore this PR, it's only opened for test running code through the PR test pipeline.

>From d52815e790c40a32cc164527957f700c11edff9c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin at martin.st>
Date: Mon, 20 Jan 2025 10:51:18 +0200
Subject: [PATCH 1/2] [libcxx] [ci] Don't use the "-s" flag in LLVM_LIT_ARGS

The "-s" flag gives a nice visual progress bar when running lit,
which is useful when running interactively, but makes the log
output near illegible.

Additionally, by omitting "-s", the CI log becomes much more useful,
as it prints the outcome of each individual test (by printing
"PASS" or "UNSUPPORTED" or "XFAIL" for each one), making it
clearer which tests were executed and which were skipped.
---
 libcxx/utils/ci/run-buildbot | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index f1ede6474eb9ee..ec3dcdb8628a31 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -136,7 +136,7 @@ function generate-cmake-base() {
           -DLIBCXX_ENABLE_WERROR=YES \
           -DLIBCXXABI_ENABLE_WERROR=YES \
           -DLIBUNWIND_ENABLE_WERROR=YES \
-          -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+          -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
           "${@}"
 }
 
@@ -391,7 +391,7 @@ bootstrapping-build)
           -DLLVM_TARGETS_TO_BUILD="host" \
           -DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
           -DLLVM_ENABLE_ASSERTIONS=ON \
-          -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
+          -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
 
     step "Running the libc++ and libc++abi tests"
     ${NINJA} -vC "${BUILD_DIR}" check-runtimes
@@ -564,7 +564,7 @@ apple-system-hardened)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/cxx" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
         -DLIBCXX_CXX_ABI=libcxxabi \
         -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake" \
@@ -580,7 +580,7 @@ apple-system-hardened)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/unwind" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libunwind" \
         -DLIBUNWIND_TEST_CONFIG="apple-libunwind-system.cfg.in" \
         -DLIBUNWIND_TEST_PARAMS="${params}" \
@@ -610,7 +610,7 @@ apple-system)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/cxx" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
         -DLIBCXX_CXX_ABI=libcxxabi \
         -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake" \
@@ -626,7 +626,7 @@ apple-system)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/unwind" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libunwind" \
         -DLIBUNWIND_TEST_CONFIG="apple-libunwind-system.cfg.in" \
         -DLIBUNWIND_TEST_PARAMS="${params}" \

>From 4d7f13c41c9516e9a8cb4d6b3fc398f76708eb91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin at martin.st>
Date: Mon, 20 Jan 2025 10:56:14 +0200
Subject: [PATCH 2/2] Revert "[libcxx][test] Fix a test for the range of file
 offsets on ARMv7 Linux targets.

Test to see how the CI fares with this XFAIL removed, on some of
the other CI configurations (where it was unclear whether they were
executed or not before).
---
 .../fstreams/ifstream.members/offset_range.pass.cpp          | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 6ffe750564c2c9..5afd4465db31e0 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -28,11 +28,6 @@
 //
 // XFAIL: target=powerpc-{{.+}}-aix{{.*}}
 
-// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
-// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
-//
-// UNSUPPORTED: target=armv7-unknown-linux-gnueabihf
-
 #include <fstream>
 #include <iostream>
 #include <cassert>