[libcxx-commits] [libcxx] [libcxx] [test] Add a test for the range of file offsets (PR #122798)

[Vladimir Vereschaka via libcxx-commits]

Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/122798 at github.com>


vvereschaka wrote:

@mstorsjo ,

> @kazutakahirata This test seems to fail on the [llvm-clang-win-x-armv7l](https://lab.llvm.org/buildbot/#/builders/38) buildbot, which it seems that you maintain: https://lab.llvm.org/buildbot/#/builders/38/builds/1855
> 
> The test fails like this:
> 
> ```
> offset_range.pass.cpp:54: void test_tellg(std::streamoff): Assertion `!ofs.fail()' failed.
> ```
> 
> This probably means that the runner didn't have space to create the 4 GB temporary file used in this test.

This is cross-platform builder Win to Armv7 Linux. The tests is running on a armv7 (32 bit) development board with a limited disk space (8 Gb total). I freed 5.5G on the dev board, but anyway the test gets failed with the ``!ofs.fail()' failed` error. Looks like the problem is not only a missing free 4Gb space.

>We have a libcxx testsuite flag large_tests, so one can set up the testsuite to run e.g. like - DLIBCXX_TEST_PARAMS="large_tests=False", which should exclude tests that require a large amount of memory to run. I wonder if we'd need to add a similar flag here?

Would be helpful I suppose. The test takes 78 secs on the board even if it gets failed (single thread)
```
********************
Slowest Tests:
--------------------------------------------------------------------------
76.53s: llvm-libc++-static.cfg.in :: std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
```

and it takes 270 secs on Aarch64 board (32 threads, Jetson AGX) when passed:
```
Slowest Tests:
--------------------------------------------------------------------------
268.93s: llvm-libc++-static.cfg.in :: std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
97.36s: llvm-libc++-static.cfg.in :: std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
89.58s: llvm-libc++-static.cfg.in :: std/utilities/variant/variant.visit/visit_return_type.pass.cpp
...
```
https://lab.llvm.org/buildbot/#/builders/193/builds/4935/steps/15/logs/stdio

https://github.com/llvm/llvm-project/pull/122798