[libcxx-commits] [libcxx] [libc++] Fix hardening checks in std::string operator[] (PR #122414)

[Peng Liu via libcxx-commits]

winner245 wrote:

You are totally right! Thank you so much for correcting me! Thank you for pointing that out. The null terminator did cross my mind initially when I was evaluating this check, but I overlooked it.

It appears we are still lacking some tests for these hardening checks. Typically, we have asset.pass.cpp for such checks, but I couldn't find one for `basic_string`. It seems we will need to add this test at some point.

https://github.com/llvm/llvm-project/pull/122414