[libcxx-commits] [libcxx] [libc++] Put _LIBCPP_NODEBUG on all internal aliases (PR #118710)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> This has been in the tree for all of a day. Is this really going to cause a problem so quickly?

This patch touches a lot of files and we already had two cases where this caused issues (specifically, the check wasn't run on the PRs yet and then caught issues after landing).

> And clang crashing seems kind of worse – there are reports of several distinct problems on this PR. Why is this exempt from llvm's revert-to-green policy?

This isn't exempt from the policy. However, my experience has been that if you revert before getting an actual reproducer you don't get one unless you push really hard. This is of course not always the case, but it's also not exactly a rare thing. I usually don't consider "here is a log" a reproducer, since the failures almost always are way outside my field of expertise (e.g. lldb in this case), which means I have to either spend lots of time figuring our what's actually going on, or ask the person who reported the issue and _hope_ that they respond. In this very instance I didn't get a reproducer from either the original person who reported the issue or the person who asked for the revert. A third person had to give me something to actually look at. If I had reverted I most likely wouldn't have gotten that reproducer simply because @aeubanks probably would have taken a look and noticed that it's already been reverted and then not noticing that I didn't actually have a reproducer.

(FYI I've uploaded #122393 to fix the crashes temporarily)


https://github.com/llvm/llvm-project/pull/118710