[libcxx-commits] [libcxx] [libc++] Add __iswctype to the locale base API since it's required by <locale> (PR #122168)

[Louis Dionne via libcxx-commits]

ldionne wrote:

@mysterymath How does Fuchsia define `iswspace_l` & friends? I suspect you'd simply need to add a similar definition for `iswspace_l`.

@petrhosek We've talked about pre-commit CI for Fuchsia more times than I can remember and for years (literally). The way Fuchsia currently interacts with libc++ for these issues is very disruptive, since errors like this are brought up at random moments and after they've been landed. To be clear, I know there's no ill intent from anyone here and it's just a result of the lack of pre-commit CI, but it's still disruptive.

Fuchsia is the only platform that (for some reason) we've tolerated this for. We made a hard request for pre-commit CI to all other officially supported platforms, which they've done. Please consider this an official "hard request" to provide pre-commit CI. I can work with you on setting it up, and once that's done we'll be happy to list Fuchsia as supported on https://libcxx.llvm.org and address issues before they hit `main`. However, if this doesn't get addressed, we'll start serving the "oh well Fuchsia is not supported" argument in order to protect our productivity. Like I said, I don't think setting this up is even difficult and I'm willing to spend time with you to get it up and running. But I can't do it alone, so what I'm trying to do here in this comment is give you an incentive to prioritize that work.

https://github.com/llvm/llvm-project/pull/122168