[libcxx-commits] [libcxx] Non-constant instances have been made constant in data_const.pass.cpp (PR #122085)

Peng Liu via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 8 10:38:07 PST 2025


winner245 wrote:

> @winner245, considered that the failure if the checks for code formatting can be ignored in this case, is the pull request eligible to be merged?

The PR looks good to me. However, I don’t have merge access. I suggest we wait for the upcoming clang-format run on all libcxx tests, as mentioned by @ldionne. By then, your formatting issue should be resolved automatically with a rebase onto the main branch, allowing a maintainer to merge your PR.

https://github.com/llvm/llvm-project/pull/122085


More information about the libcxx-commits mailing list