[libcxx-commits] [libcxx] [libc++] use copy_file_range for fs::copy (PR #109211)

[Vladimir Vereschaka via libcxx-commits]

Jannik =?utf-8?q?Glückert?= <jannik.glueckert at gmail.com>,Louis Dionne
 <ldionne.2 at gmail.com>,Louis Dionne <ldionne.2 at gmail.com>,Louis Dionne
 <ldionne.2 at gmail.com>,
Jannik =?utf-8?q?Glückert?= <jannik.glueckert at gmail.com>,
Jannik =?utf-8?q?Glückert?= <jannik.glueckert at gmail.com>,
Jannik =?utf-8?q?Glückert?= <jannik.glueckert at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/109211 at github.com>


vvereschaka wrote:

We got the following build error for the cross builds (win to armv7 linux)

https://lab.llvm.org/buildbot/#/builders/38/builds/1661
```
AILED: libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.o 
C:\buildbot\as-builder-1\x-armv7l\build\.\bin\clang++.exe --target=armv7-unknown-linux-gnueabihf -DLIBCXX_BUILDING_LIBCXXABI -DLIBC_NAMESPACE=__llvm_libc_common_utils -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:/buildbot/as-builder-1/x-armv7l/llvm-project/libcxx/src -IC:/buildbot/as-builder-1/x-armv7l/build/include/armv7-unknown-linux-gnueabihf/c++/v1 -IC:/buildbot/as-builder-1/x-armv7l/build/include/c++/v1 -IC:/buildbot/as-builder-1/x-armv7l/llvm-project/libcxxabi/include -IC:/buildbot/as-builder-1/x-armv7l/llvm-project/runtimes/cmake/Modules/../../../libc -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -fsized-deallocation -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wzero-length-array -Wdeprecated-redundant-constexpr-static-def -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -std=c++2b -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.o -MF libcxx\src\CMakeFiles\cxx_static.dir\filesystem\operations.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.o -c C:/buildbot/as-builder-1/x-armv7l/llvm-project/libcxx/src/filesystem/operations.cpp
C:/buildbot/as-builder-1/x-armv7l/llvm-project/libcxx/src/filesystem/operations.cpp:246:46: error: cannot initialize a parameter of type '__off64_t *' (aka 'long long *') with an rvalue of type 'off_t *' (aka 'long *')
  246 |     if ((res = ::copy_file_range(read_fd.fd, &off_in, write_fd.fd, &off_out, count, 0)) == -1) {
      |                                              ^~~~~~~
c:/buildbot/fs/jetson-tk1-arm-ubuntu/usr/include\unistd.h:1110:49: note: passing argument to parameter '__pinoff' here
 1110 | ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
      |                                                 ^
1 error generated.
```

https://github.com/llvm/llvm-project/pull/109211