[libcxx-commits] [clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

[Vlad Serebrennikov via libcxx-commits]

================
@@ -174,6 +174,26 @@ static_assert(!__is_layout_compatible(StructWithAnonUnion, StructWithAnonUnion3)
 #endif
 } // namespace cwg2759
 
+#if __cplusplus >= 202002L
+namespace cwg2770 { // cwg2770: 20
----------------
Endilll wrote:

> Yes, I implemented what that issue proposed.

Good to know! I fixed it with NFC commits myself, no worries.

> I saw the script removing the entire cwg2770 line after I added this test.

What happened is that script has printed `Issue 2770 is marked '', which differs from CWG index status 'open'`, and stopped right there, before emitting HTML for CWG2770. I guess in order to clear the confusion, I should update the script to not write anything to file until it's sure everything is good.

> Could you instruct me on what to do with it? Should we leave out the test until the issue gets resolved?

No, the script is able to handle tests for not yet resolved issues. That's how you do it:
https://github.com/llvm/llvm-project/blob/1229b78f1676d56d0d386a5c4cde8f98a78d0989/clang/test/CXX/drs/cwg27xx.cpp#L177

I also moved CWG2369 test from the end of `cwg23xx.cpp` right before CWG2370 test, because that's how DR tests are ordered.

https://github.com/llvm/llvm-project/pull/102857