[libcxx-commits] [clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

[Younan Zhang via libcxx-commits]

================
@@ -6089,16 +6090,16 @@ bool TreeTransform<Derived>::TransformFunctionTypeParams(
     const FunctionProtoType::ExtParameterInfo *ParamInfos,
     SmallVectorImpl<QualType> &OutParamTypes,
     SmallVectorImpl<ParmVarDecl *> *PVars,
-    Sema::ExtParameterInfoBuilder &PInfos,
-    unsigned *LastParamTransformed) {
+    Sema::ExtParameterInfoBuilder &PInfos, unsigned *LastParamTransformed,
+    bool IgnoreParameterIndex) {
----------------
zyn0217 wrote:

Yes, and the assertion feels awkward in this case because we only instantiate what we use, which is something we’ve never done with function parameters.

I don’t recall seeing any warnings, even for my local release build, but my memory on that is a bit unclear. I’ll look into it soon.

https://github.com/llvm/llvm-project/pull/102857