[libcxx-commits] [libcxx] [libc++][test] extend -linux-gnu XFAIL to cover all of the -linux targets (PR #129140)

[Louis Dionne via libcxx-commits]

ldionne wrote:

I'll echo what @philnik777 said here: please don't bypass the libc++ reviewers group. I'm not too comfortable with folks who don't have a history of contributing to libc++ merging commits themselves into the codebase without approval from the usual reviewers group. I know you had absolutely no wrong intentions, it was a small patch, and that's okay. What I'm expressing is discomfort with the fact that this is even technically feasible, since Github gives us means to easily avoid that.

CC @tstellar FWIW, this is a great example of something where different commit access policies could be helpful. In this case, there was no intention of wrongdoing, but unclear policies around who's expected to merge something led to a small and mostly harmless, but incorrect patch being merged (since it had to be reverted). I only stumbled upon that because I `git log -- libcxx` almost every day, and I think it's unfortunate that I've been feeling the need to do that in order to fulfill my duties as a code owner (which says specifically that I'm responsible for every change being reviewed appropriately).

Anyway, there's no harm done here but I do think this is something small and inconsequential that we can learn from in terms of setting project policies.

https://github.com/llvm/llvm-project/pull/129140