[libcxx-commits] [libcxx] [libcxx] Export directory_iterator in module build (PR #129195)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 27 21:47:09 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Takuto Ikuta (atetubou)

<details>
<summary>Changes</summary>

This is workaround for the link error like https://crbug.com/390537876.

Might be related to https://github.com/llvm/llvm-project/issues/120108 too.

---
Full diff: https://github.com/llvm/llvm-project/pull/129195.diff


1 Files Affected:

- (modified) libcxx/include/module.modulemap (+5-1) 


``````````diff
diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap
index 0f2016e7f5d15..f94b6fc519399 100644
--- a/libcxx/include/module.modulemap
+++ b/libcxx/include/module.modulemap
@@ -1229,7 +1229,11 @@ module std [system] {
   module filesystem {
     module copy_options                   { header "__filesystem/copy_options.h" }
     module directory_entry                { header "__filesystem/directory_entry.h" }
-    module directory_iterator             { header "__filesystem/directory_iterator.h" }
+    module directory_iterator             {
+      header "__filesystem/directory_iterator.h"
+      // This is a workaround for https://github.com/llvm/llvm-project/issues/120108.
+      export *
+    }
     module directory_options              { header "__filesystem/directory_options.h" }
     module file_status                    { header "__filesystem/file_status.h" }
     module file_time_type                 { header "__filesystem/file_time_type.h" }

``````````

</details>


https://github.com/llvm/llvm-project/pull/129195


More information about the libcxx-commits mailing list