[libcxx-commits] [libcxx] [libc++] Fix the locale base API on Linux with musl (PR #128936)

[via libcxx-commits]

pirama-arumuga-nainar wrote:

> > LGTM, thanks for the fix and sorry for the slow reaction time.
> > Do you know if this means we can actually get rid of this code path in `locale_base_api.h`?
> > ```
> > #  elif defined(__wasi__) || _LIBCPP_HAS_MUSL_LIBC
> > #    include <__locale_dir/locale_base_api/musl.h>
> > ```
> 
> This change shouldn't impact `__wasi__` targets. Should we include `__wasi__` in these changes to `__strtoll()`, `__strtoull()`?

The separate definitions are still needed for `wasi` - it's not a Linux environment.  .  We could rename the file to `wasi.h` to make this explicit.

> So I'll add a Co-authored-by to the message if that's satisfactory @pirama-arumuga-nainar

Thanks for the credit, but no need to go out of the way for this.  I'm happy to just have the breakage fixed.

https://github.com/llvm/llvm-project/pull/128936