[libcxx-commits] [libcxx] [libc++] Re-enable the FreeBSD CI job (PR #127687)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/127687

>From 1ee59940b0a9091e62de9ebe7274dfce7e4d69a0 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 18 Feb 2025 14:22:44 -0500
Subject: [PATCH 1/3] [libc++] Re-enable the FreeBSD CI job

Technical issues have apparently been resolved and
the node should be back online.

Closes #117780.
---
 libcxx/utils/ci/buildkite-pipeline.yml | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index df0e5d4d12f9f..b8e982b653d39 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -115,19 +115,17 @@ steps:
       os: aix
     <<: *common
 
-# TODO: Re-enable this when the FreeBSD runners are back online
-#       https://github.com/llvm/llvm-project/issues/117780
-# - group: ':freebsd: FreeBSD'
-#   steps:
-#   - label: FreeBSD 13 amd64
-#     command: libcxx/utils/ci/run-buildbot generic-cxx26
-#     env:
-#       CC: clang17
-#       CXX: clang++17
-#     agents:
-#       queue: libcxx-builders
-#       os: freebsd
-#     <<: *common
+- group: ':freebsd: FreeBSD'
+  steps:
+  - label: FreeBSD 13 amd64
+    command: libcxx/utils/ci/run-buildbot generic-cxx26
+    env:
+      CC: clang17
+      CXX: clang++17
+    agents:
+      queue: libcxx-builders
+      os: freebsd
+    <<: *common
 
 - group: ':android: Android'
   steps:

>From 924411b6332badc749bcbc331e054068937bca13 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 18 Feb 2025 14:28:38 -0500
Subject: [PATCH 2/3] Bump Clang version on FreeBSD

---
 libcxx/utils/ci/buildkite-pipeline.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index b8e982b653d39..3f3e6b466c9ce 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -120,8 +120,8 @@ steps:
   - label: FreeBSD 13 amd64
     command: libcxx/utils/ci/run-buildbot generic-cxx26
     env:
-      CC: clang17
-      CXX: clang++17
+      CC: clang19
+      CXX: clang++19
     agents:
       queue: libcxx-builders
       os: freebsd

>From f788910b3435073e8e044c5df1b8c32f2d31fd03 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Thu, 20 Feb 2025 08:21:54 -0500
Subject: [PATCH 3/3] Xfails

---
 .../locale.moneypunct.byname/grouping.pass.cpp                 | 2 --
 .../utility/pairs/pairs.pair/nttp.equivalence.compile.pass.cpp | 3 +++
 .../std/utilities/utility/pairs/pairs.pair/nttp.verify.cpp     | 3 +++
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp b/libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp
index 3243db6a5cca6..a8d74d9b8472a 100644
--- a/libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp
@@ -11,8 +11,6 @@
 // NetBSD does not support LC_MONETARY at the moment
 // XFAIL: netbsd
 
-// XFAIL: LIBCXX-FREEBSD-FIXME
-
 // REQUIRES: locale.en_US.UTF-8
 // REQUIRES: locale.fr_FR.UTF-8
 // REQUIRES: locale.ru_RU.UTF-8
diff --git a/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.equivalence.compile.pass.cpp b/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.equivalence.compile.pass.cpp
index f5fd5a674882b..33b59fddcfcef 100644
--- a/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.equivalence.compile.pass.cpp
+++ b/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.equivalence.compile.pass.cpp
@@ -14,6 +14,9 @@
 // Two values p1 and p2 of type pair<T, U> are template-argument-equivalent ([temp.type]) if and only if
 // p1.first and p2.first are template-argument-equivalent and p1.second and p2.second are template-argument-equivalent.
 
+// This deprecated ABI switch makes pair a non-structural type.
+// XFAIL: libcpp-deprecated-abi-disable-pair-trivial-copy-ctor
+
 #include <utility>
 
 #include <type_traits>
diff --git a/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.verify.cpp b/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.verify.cpp
index 499ba6b243bed..b9b5432a30b21 100644
--- a/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.verify.cpp
+++ b/libcxx/test/std/utilities/utility/pairs/pairs.pair/nttp.verify.cpp
@@ -13,6 +13,9 @@
 // LWG-3382 NTTP for pair and array:
 // pair<T, U> is a structural type ([temp.param]) if T and U are both structural types.
 
+// This deprecated ABI switch makes pair a non-structural type.
+// XFAIL: libcpp-deprecated-abi-disable-pair-trivial-copy-ctor
+
 #include <utility>
 
 #include <functional>