[libcxx-commits] [libcxx] [libc++][NFC] Add reminder to remove _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER macro (PR #127070)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 13 07:06:45 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

<details>
<summary>Changes</summary>

`__cpp_explicit_this_parameter` has been set in LLVM20
https://github.com/llvm/llvm-project/pull/107451

---
Full diff: https://github.com/llvm/llvm-project/pull/127070.diff


1 Files Affected:

- (modified) libcxx/include/__config (+2) 


``````````diff
diff --git a/libcxx/include/__config b/libcxx/include/__config
index ca6aade34107b..5c8c72fce5921 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -1198,6 +1198,8 @@ typedef __char32_t char32_t;
 #    define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK
 #  endif
 
+// TODO(LLVM 22): Remove this macro once LLVM19 support ends. __cpp_explicit_this_parameter has been set in LLVM20
+// https://github.com/llvm/llvm-project/pull/107451
 // Clang-18 has support for deducing this, but it does not set the FTM.
 #  if defined(__cpp_explicit_this_parameter) || (defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER >= 1800)
 #    define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 1

``````````

</details>


https://github.com/llvm/llvm-project/pull/127070


More information about the libcxx-commits mailing list