[libcxx-commits] [libcxx] [libc++] Fix ambiguous call in {ranges, std}::find (PR #122641)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 11 01:03:50 PST 2025


================
@@ -206,6 +208,33 @@ struct TestIntegerPromotions {
   }
 };
 
+TEST_CONSTEXPR_CXX20 void test_bit_iterator_with_custom_sized_types() {
----------------
ldionne wrote:

In general, we favour using something like this instead of introducing new functions for test cases:

```
bool test() {
  // lots of things...

  // Test std::vector<bool>::iterator with an allocator that has a custom size type
  {
    // your added test cases
  }
}
```

There are many situations in which this is not possible, but when possible, we favour this over adding a function named `test_bit_iterator_with_custom_sized_types` since that allows explaining the test case in plain english and keeps the complexity of the test down.

https://github.com/llvm/llvm-project/pull/122641


More information about the libcxx-commits mailing list