[libcxx-commits] [libcxx] [libc++] Revert "Do not redeclare lgamma_r when targeting the LLVM C library (#102036) (PR #125587)
Joseph Huber via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 4 09:59:23 PST 2025
jhuber6 wrote:
> My strong preference would be to include a standard header instead, but that would require LLVM libc to define its detection macro when such header is included.
>
> I'd be okay with a partial revert only, but @jhuber6 would have to tell me what the check should be instead.
I think we already have a handful of `__LLVM_LIBC__` tests that might also break on baremetal, cc @petrhosek.
> LLVM libc should instead provide a more standard way of getting configuration macros like LLVM_LIBC.
But `features.h` is the standard way on Linux at least. We could always emit `__features.h` or something if we're really concerned.
https://github.com/llvm/llvm-project/pull/125587
More information about the libcxx-commits
mailing list