[libcxx-commits] [libcxx] [libc++][atomic] Applied `[[nodiscard]]` (PR #173962)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libcxx/test/libcxx/atomics/nodiscard.verify.cpp libcxx/include/__atomic/atomic.h libcxx/include/__atomic/atomic_ref.h libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
index 7662ac03f..325186a1a 100644
--- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -21,26 +21,34 @@ void f() {
     int val2 = 2; ((void)val2);
     // load operations
     {
-        (void)x.load(std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)x.load(std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)vx.load(std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)vx.load(std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
-        // valid memory orders
-        (void)x.load(std::memory_order_relaxed);
-        (void)x.load(std::memory_order_consume);
-        (void)x.load(std::memory_order_acquire);
-        (void)x.load(std::memory_order_seq_cst);
+      (void)x.load(
+          std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)x.load(
+          std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)vx.load(
+          std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)vx.load(
+          std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
+      // valid memory orders
+      (void)x.load(std::memory_order_relaxed);
+      (void)x.load(std::memory_order_consume);
+      (void)x.load(std::memory_order_acquire);
+      (void)x.load(std::memory_order_seq_cst);
     }
     {
-        (void)std::atomic_load_explicit(&x, std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)std::atomic_load_explicit(&x, std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)std::atomic_load_explicit(&vx, std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
-        (void)std::atomic_load_explicit(&vx, std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
-        // valid memory orders
-        (void)std::atomic_load_explicit(&x, std::memory_order_relaxed);
-        (void)std::atomic_load_explicit(&x, std::memory_order_consume);
-        (void)std::atomic_load_explicit(&x, std::memory_order_acquire);
-        (void)std::atomic_load_explicit(&x, std::memory_order_seq_cst);
+      (void)std::atomic_load_explicit(
+          &x, std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)std::atomic_load_explicit(
+          &x, std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)std::atomic_load_explicit(
+          &vx, std::memory_order_release); // expected-warning {{memory order argument to atomic operation is invalid}}
+      (void)std::atomic_load_explicit(
+          &vx, std::memory_order_acq_rel); // expected-warning {{memory order argument to atomic operation is invalid}}
+      // valid memory orders
+      (void)std::atomic_load_explicit(&x, std::memory_order_relaxed);
+      (void)std::atomic_load_explicit(&x, std::memory_order_consume);
+      (void)std::atomic_load_explicit(&x, std::memory_order_acquire);
+      (void)std::atomic_load_explicit(&x, std::memory_order_seq_cst);
     }
     // store operations
     {

``````````

</details>


https://github.com/llvm/llvm-project/pull/173962