[libcxx-commits] [libcxx] [libc++] Default the allocator argument for most string constructors (PR #169901)

[David Spickett via libcxx-commits]

DavidSpickett wrote:

I don't immediately see why this change would be related to the error:
```
---command stderr------------
| ld.lld: error: section '.except_ordered' will not fit in region 'flash': overflowed by 3456 bytes
| ld.lld: error: section '.except_ordered' will not fit in region 'flash': overflowed by 3456 bytes
| ld.lld: error: section '.eh_frame' will not fit in region 'flash': overflowed by 3500 bytes
| ld.lld: error: section '.eh_frame' will not fit in region 'flash': overflowed by 3500 bytes
| ld.lld: error: section '.except_unordered' will not fit in region 'flash': overflowed by 9632 bytes
| ld.lld: error: section '.except_unordered' will not fit in region 'flash': overflowed by 9632 bytes
| ld.lld: error: section '.data' will not fit in region 'flash': overflowed by 9680 bytes
| ld.lld: error: section '.tdata' will not fit in region 'flash': overflowed by 9680 bytes
| clang++: error: linker command failed with exit code 1 (use -v to see invocation)
`-----------------------------
error: command failed with exit status: 1
```
Then again, this is not the sort of error I'd expect to see when a test is flakey unless there's non-determinism in the linker.

I will check for that locally. I know we have some tests disabled purely due to binary size, this might have to be another one.

https://github.com/llvm/llvm-project/pull/169901