[libcxx-commits] [libcxx] [libc++][char_traits] Applied `[[nodiscard]]` (PR #172244)

[A. Jiang via libcxx-commits]

================
@@ -257,16 +268,16 @@ struct char_traits<wchar_t> : __char_traits_base<wchar_t, wint_t, static_cast<wi
 
 template <>
 struct char_traits<char8_t> : __char_traits_base<char8_t, unsigned int, static_cast<unsigned int>(EOF)> {
-  static _LIBCPP_HIDE_FROM_ABI constexpr int
+  [[nodiscard]] static _LIBCPP_HIDE_FROM_ABI constexpr int
----------------
frederick-vs-ja wrote:

Note for review: Non-uglified `nodiscard` occurrences can only appear since C++20 currently, while other uglified `__nodiscard__` occurrences can appear in C++03.

https://github.com/llvm/llvm-project/pull/172244