[libcxx-commits] [libcxx] Fix char traits eq hide from abi (PR #171020)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Shlok Mundhra (smundhra-git)

<details>
<summary>Changes</summary>

[libcxx] Replace _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI in char_traits::eq

This removes the TODO comment and makes the eq function consistent
with the lt function below it, which already uses _LIBCPP_HIDE_FROM_ABI.

---
Full diff: https://github.com/llvm/llvm-project/pull/171020.diff


1 Files Affected:

- (modified) libcxx/include/__string/char_traits.h (+1-2) 


``````````diff
diff --git a/libcxx/include/__string/char_traits.h b/libcxx/include/__string/char_traits.h
index 8292750919427..70b0f92639873 100644
--- a/libcxx/include/__string/char_traits.h
+++ b/libcxx/include/__string/char_traits.h
@@ -93,8 +93,7 @@ struct char_traits<char> {
     __c1 = __c2;
   }
 
-  // TODO: Make this _LIBCPP_HIDE_FROM_ABI
-  static inline _LIBCPP_HIDDEN _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
+  static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
     return __c1 == __c2;
   }
   static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool lt(char_type __c1, char_type __c2) _NOEXCEPT {

``````````

</details>


https://github.com/llvm/llvm-project/pull/171020