[libcxx-commits] [libcxx] Fix char traits eq hide from abi (PR #171020)

[Shlok Mundhra via libcxx-commits]

https://github.com/smundhra-git created https://github.com/llvm/llvm-project/pull/171020

[libcxx] Replace _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI in char_traits::eq

This removes the TODO comment and makes the eq function consistent
with the lt function below it, which already uses _LIBCPP_HIDE_FROM_ABI.

>From 00a87b74695c59f5baad5dc92ef17eb14019c8d5 Mon Sep 17 00:00:00 2001
From: smundhra-git <shlokmundhra1111 at gmail.com>
Date: Sun, 7 Dec 2025 03:33:38 -0500
Subject: [PATCH 1/2] [libcxx] Replace _LIBCPP_HIDDEN with
 _LIBCPP_HIDE_FROM_ABI in char_traits::eq

---
 libcxx/include/__string/char_traits.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/include/__string/char_traits.h b/libcxx/include/__string/char_traits.h
index 8292750919427..4d0da0fd4ef09 100644
--- a/libcxx/include/__string/char_traits.h
+++ b/libcxx/include/__string/char_traits.h
@@ -94,7 +94,7 @@ struct char_traits<char> {
   }
 
   // TODO: Make this _LIBCPP_HIDE_FROM_ABI
-  static inline _LIBCPP_HIDDEN _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
+  static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
     return __c1 == __c2;
   }
   static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool lt(char_type __c1, char_type __c2) _NOEXCEPT {

>From ba1b82e6358118cfccdbf6eb2e0f0a8e54835540 Mon Sep 17 00:00:00 2001
From: smundhra-git <shlokmundhra1111 at gmail.com>
Date: Sun, 7 Dec 2025 03:34:00 -0500
Subject: [PATCH 2/2] [libcxx] Replace _LIBCPP_HIDDEN with
 _LIBCPP_HIDE_FROM_ABI in char_traits::eq - resolved a TODO

---
 libcxx/include/__string/char_traits.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libcxx/include/__string/char_traits.h b/libcxx/include/__string/char_traits.h
index 4d0da0fd4ef09..70b0f92639873 100644
--- a/libcxx/include/__string/char_traits.h
+++ b/libcxx/include/__string/char_traits.h
@@ -93,7 +93,6 @@ struct char_traits<char> {
     __c1 = __c2;
   }
 
-  // TODO: Make this _LIBCPP_HIDE_FROM_ABI
   static inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool eq(char_type __c1, char_type __c2) _NOEXCEPT {
     return __c1 == __c2;
   }