[libcxx-commits] [libcxx] [libcxx] Minor fixes of tests for flat_[multi]{set, map} for compatibility with MSVC (PR #170493)
Vojtěch Michal via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Dec 5 10:28:33 PST 2025
vmichal wrote:
Thank you for the insight I lacked. I am in no position to assess, let alone comment on the relationship between implementations, so I don't mean to object.
This PR is no longer necessary as MSVC is improving its conformance (P2448R2); however, I have a second branch of changes (with fewer impacted files and more focused changes) related to narrowing conversions in some flat_foo tests. I have already discussed them on the LLVM discord and got some implementation recommendations from Hui Xie
(https://discord.com/channels/636084430946959380/636732894974312448/1445901676400742533). I have those changes ready, waiting to open a PR.
Should I read your comment as a recommendation not to open any PRs? Or you'd be willing to consider a more relevant PR? I will, of course, provide more details in the PR itself when it's open. Thanks in advance.
https://github.com/llvm/llvm-project/pull/170493
More information about the libcxx-commits
mailing list