[libcxx-commits] [libcxx] [libc++] Fix num_get base parsing (PR #170460)
via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Dec 3 02:49:59 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- libcxx/include/__locale_dir/num.h libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp b/libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
index 45b034833..db9c4585d 100644
--- a/libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
@@ -670,101 +670,101 @@ int main(int, char**)
assert(v == std::numeric_limits<long>::min());
}
- { // Check that auto-detection of the base works properly
- ios.flags(ios.flags() & ~std::ios::basefield);
- { // zeroes
- {
- v = -1;
- const char str[] = "0";
- std::ios_base::iostate err = ios.goodbit;
+ { // Check that auto-detection of the base works properly
+ ios.flags(ios.flags() & ~std::ios::basefield);
+ { // zeroes
+ {
+ v = -1;
+ const char str[] = "0";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 1), ios, err, v);
- assert(base(iter) == str + 1);
- assert(err == ios.eofbit);
- assert(v == 0);
- }
- {
- v = -1;
- const char str[] = "00";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 1), ios, err, v);
+ assert(base(iter) == str + 1);
+ assert(err == ios.eofbit);
+ assert(v == 0);
+ }
+ {
+ v = -1;
+ const char str[] = "00";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
- assert(base(iter) == str + 2);
- assert(err == ios.eofbit);
- assert(v == 0);
- }
- {
- v = -1;
- const char str[] = "0x0";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
+ assert(base(iter) == str + 2);
+ assert(err == ios.eofbit);
+ assert(v == 0);
+ }
+ {
+ v = -1;
+ const char str[] = "0x0";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
- assert(base(iter) == str + 3);
- assert(err == ios.eofbit);
- assert(v == 0);
- }
- {
- v = -1;
- const char str[] = "0X0";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
+ assert(base(iter) == str + 3);
+ assert(err == ios.eofbit);
+ assert(v == 0);
+ }
+ {
+ v = -1;
+ const char str[] = "0X0";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
- assert(base(iter) == str + 3);
- assert(err == ios.eofbit);
- assert(v == 0);
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
+ assert(base(iter) == str + 3);
+ assert(err == ios.eofbit);
+ assert(v == 0);
+ }
}
- }
- { // first character after base is out of range
- {
- v = -1;
- const char str[] = "08";
- std::ios_base::iostate err = ios.goodbit;
+ { // first character after base is out of range
+ {
+ v = -1;
+ const char str[] = "08";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
- assert(base(iter) == str + 1);
- assert(err == ios.goodbit);
- assert(v == 0);
- }
- {
- v = -1;
- const char str[] = "1a";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
+ assert(base(iter) == str + 1);
+ assert(err == ios.goodbit);
+ assert(v == 0);
+ }
+ {
+ v = -1;
+ const char str[] = "1a";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
- assert(base(iter) == str + 1);
- assert(err == ios.goodbit);
- assert(v == 1);
- }
- {
- v = -1;
- const char str[] = "0xg";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 2), ios, err, v);
+ assert(base(iter) == str + 1);
+ assert(err == ios.goodbit);
+ assert(v == 1);
+ }
+ {
+ v = -1;
+ const char str[] = "0xg";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
- assert(base(iter) == str + 2);
- assert(err == ios.failbit);
- assert(v == 0);
- }
- {
- v = -1;
- const char str[] = "0Xg";
- std::ios_base::iostate err = ios.goodbit;
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
+ assert(base(iter) == str + 2);
+ assert(err == ios.failbit);
+ assert(v == 0);
+ }
+ {
+ v = -1;
+ const char str[] = "0Xg";
+ std::ios_base::iostate err = ios.goodbit;
- cpp17_input_iterator<const char*> iter =
- f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
- assert(base(iter) == str + 2);
- assert(err == ios.failbit);
- assert(v == 0);
+ cpp17_input_iterator<const char*> iter =
+ f.get(cpp17_input_iterator<const char*>(str), cpp17_input_iterator<const char*>(str + 3), ios, err, v);
+ assert(base(iter) == str + 2);
+ assert(err == ios.failbit);
+ assert(v == 0);
+ }
}
}
- }
return 0;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/170460
More information about the libcxx-commits
mailing list