[libcxx-commits] [libcxx] Add C++23 stacktrace (P0881R7) (PR #136528)

[Steve O'Brien via libcxx-commits]

================
@@ -3966,19 +3966,19 @@ _LIBCPP_HIDE_FROM_ABI basic_istream<_CharT, _Traits>&
 operator>>(basic_istream<_CharT, _Traits>& __is, basic_string<_CharT, _Traits, _Allocator>& __str);
 
 template <class _CharT, class _Traits, class _Allocator>
-_LIBCPP_HIDE_FROM_ABI basic_istream<_CharT, _Traits>&
+_LIBCPP_EXPORTED_FROM_ABI basic_istream<_CharT, _Traits>&
 getline(basic_istream<_CharT, _Traits>& __is, basic_string<_CharT, _Traits, _Allocator>& __str, _CharT __dlm);
 
 template <class _CharT, class _Traits, class _Allocator>
-inline _LIBCPP_HIDE_FROM_ABI basic_istream<_CharT, _Traits>&
+inline _LIBCPP_EXPORTED_FROM_ABI basic_istream<_CharT, _Traits>&
 getline(basic_istream<_CharT, _Traits>& __is, basic_string<_CharT, _Traits, _Allocator>& __str);
 
 template <class _CharT, class _Traits, class _Allocator>
-inline _LIBCPP_HIDE_FROM_ABI basic_istream<_CharT, _Traits>&
+inline _LIBCPP_EXPORTED_FROM_ABI basic_istream<_CharT, _Traits>&
 getline(basic_istream<_CharT, _Traits>&& __is, basic_string<_CharT, _Traits, _Allocator>& __str, _CharT __dlm);
 
 template <class _CharT, class _Traits, class _Allocator>
-inline _LIBCPP_HIDE_FROM_ABI basic_istream<_CharT, _Traits>&
+inline _LIBCPP_EXPORTED_FROM_ABI basic_istream<_CharT, _Traits>&
 getline(basic_istream<_CharT, _Traits>&& __is, basic_string<_CharT, _Traits, _Allocator>& __str);
 
----------------
elsteveogrande wrote:

Question: should these be `EXPORTED_FROM_ABI`?  I couldn't access these definitions without exporting them.  Not sure why they were hidden, or how else to solve this.

The signatures appear to match the public API.  [cppreference link, I didn't locate the paper these were introduced in](https://en.cppreference.com/w/cpp/string/basic_string/getline.html)

(If these should actually stay `EXPORTED_` then I can add this as a separate patch, along with any other unrelated changes)

https://github.com/llvm/llvm-project/pull/136528