[libcxx-commits] [libcxx] [libcxx] fix mi_mode_test failure with libc++-21 (PR #153969)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 25 23:22:02 PDT 2025


https://github.com/philnik777 requested changes to this pull request.

I'm incredibly confused. Why is there a serializer and parser now? I feel like I'm missing something here, or maybe we're talking past each other. AFAICT our implementation should print `[{"key": 1, "value": "one"}, {"key": 2, "value": "two"}, {"key": 3, "value": "three"}]` for the old test, which was already tested before this patch. This implies to me that the pretty printer is incorrect if this test fails.


https://github.com/llvm/llvm-project/pull/153969


More information about the libcxx-commits mailing list