[libcxx-commits] [libcxx] [libc++] Implement a type-safe iterator for optional (PR #154239)

[William Tran-Viet via libcxx-commits]

smallp-o-p wrote:

> IMO You should keep the commit message (the top comment) terser, on point and less opionated, as you have been asked in the previous PR. You can give more context, etc. in subsequent comments.

Fair enough.

> I am not sure but do we need libc++ specific tests for this iterator? I think they need to be placed under test/libcxx instead of test/std.

I'm not quite sure that I understand? Do you mean they need to be placed in `test/std`? Because right now the test file is placed in `test/libcxx`.


https://github.com/llvm/llvm-project/pull/154239