[libcxx-commits] [libcxx] [libc++][istream] P3223R2: Making `std::istream::ignore` less surprising (PR #147007)

[Louis Dionne via libcxx-commits]

================
@@ -292,6 +294,10 @@ public:
   basic_istream& getline(char_type* __s, streamsize __n, char_type __dlm);
 
   basic_istream& ignore(streamsize __n = 1, int_type __dlm = traits_type::eof());
+  template <class _Tp = char_type, __enable_if_t<is_same<_Tp, char>::value, int> = 0>
+  inline _LIBCPP_HIDE_FROM_ABI_AFTER_V1 basic_istream& ignore(streamsize __n, char_type __delim) {
----------------
ldionne wrote:

```suggestion
  _LIBCPP_HIDE_FROM_ABI basic_istream& ignore(streamsize __n, char_type __delim) {
```

Is there a reason for

1. marking it `inline`
2. hiding it from the ABI only after v1?


https://github.com/llvm/llvm-project/pull/147007