[libcxx-commits] [libcxx] [libc++][test] Don't pass ill-formed UTF-8 to MAKE_STRING_VIEW (PR #136403)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 19 03:03:57 PDT 2025


https://github.com/frederick-vs-ja approved this pull request.

LGTM!

Although the PR description looks a bit outdated. [CWG1656](https://cplusplus.github.io/CWG/issues/1656.html) has been resolved by [P2029R4](https://wg21.link/p2029r4), and now it's specified that each of `\x80`..`\xff` in a u8 string literal exactly produces a single `char8_t` array element. Before P2029R4 such use seemed to be ill-formed, but old versions of compilers used to silently accept it with different meanings.

https://github.com/llvm/llvm-project/pull/136403


More information about the libcxx-commits mailing list