[libcxx-commits] [libcxx] [libc++] Implement P3379R0 Constrain `std::expected` equality operators (PR #135759)

[via libcxx-commits]

yronglin wrote:

Thanks for your review!
 
> * We now use GitHub issues to track implementation: [P3379R0: Constrain std::expected equality operators #118135](https://github.com/llvm/llvm-project/issues/118135) You can use GitHub syntax to associte PR to the issue https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Thanks for reminding me, I didn't aware the change in the process before.

> * If you are interested in implementing the rest of [P2944R3: Comparisons for `reference_wrapper` #105424](https://github.com/llvm/llvm-project/issues/105424) please feel to do so.

Yes, I'd like to implement the rest of P2944R3.

> * I haven't thought about it much: would it make sense to generalize and reuse the test data between the types?

I reuse the test data between the types because it's very similar, but I have no preference. Should we revert the reuses things?



https://github.com/llvm/llvm-project/pull/135759