[libcxx-commits] [libcxx] [libcxx] Fix libcxx test, integral.pass.cpp (PR #135355)

S. B. Tam via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 11 05:46:05 PDT 2025


cpplearner wrote:

> When running the test integral.pass.cpp, it calls tries to call `strtoll`, which returns an i64, not an i128, therefore only keeping the lower 64 bits.

If the correct result would be larger than `LLONG_MAX`, `strtoll` should set `errno` to `ERANGE`, and `fromchars128_impl` would then proceed to use `from_chars` instead.

Could you please elaborate on the problem that you want to fix?

https://github.com/llvm/llvm-project/pull/135355


More information about the libcxx-commits mailing list