[libcxx-commits] [libcxx] [libc++][test][NFC] Remove unused inclusions of `<iostream>` (PR #134776)
A. Jiang via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 8 20:14:50 PDT 2025
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/134776
>From 0116beb525b558005c958d521b29e63576d21de8 Mon Sep 17 00:00:00 2001
From: "A. Jiang" <de34 at live.cn>
Date: Tue, 8 Apr 2025 11:41:33 +0800
Subject: [PATCH 1/2] [libc++][test][NFC] Remove unused inclusion of
`<iostream>`
Some test files for flat container adaptors redundantly include
`<iostream>`. This patch removes the redundant inclusions.
---
.../flat.map/flat.map.iterators/reverse_iterator.pass.cpp | 1 -
.../flat.multimap.iterators/reverse_iterator.pass.cpp | 1 -
.../flat.multiset.iterators/reverse_iterator.pass.cpp | 1 -
.../flat.set/flat.set.iterators/reverse_iterator.pass.cpp | 1 -
4 files changed, 4 deletions(-)
diff --git a/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
index fc3949d70745f..7a111e228c115 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
@@ -28,7 +28,6 @@
#include <iterator>
#include "test_macros.h"
-#include <iostream>
int main(int, char**) {
{
diff --git a/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
index 8c1e5451f703f..35b2b9f8a9e7e 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
@@ -30,7 +30,6 @@
#include <iterator>
#include "test_macros.h"
-#include <iostream>
int main(int, char**) {
{
diff --git a/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
index 9d443ef8784e2..76bd49b4abd9e 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
@@ -28,7 +28,6 @@
#include <iterator>
#include "test_macros.h"
-#include <iostream>
void test() {
{
diff --git a/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
index d1e4cef3de19e..a9ef87d483e6f 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
@@ -28,7 +28,6 @@
#include <iterator>
#include "test_macros.h"
-#include <iostream>
void test() {
{
>From f4009642c046f46d7113d5e2616a5e2d8e0b9d5f Mon Sep 17 00:00:00 2001
From: "A. Jiang" <de34 at live.cn>
Date: Wed, 9 Apr 2025 11:14:39 +0800
Subject: [PATCH 2/2] Also remove inclusions of `<cstddef>` and `<vector>`
---
.../flat.map/flat.map.iterators/reverse_iterator.pass.cpp | 2 --
.../flat.multimap.iterators/reverse_iterator.pass.cpp | 2 --
.../flat.multiset.iterators/reverse_iterator.pass.cpp | 2 --
.../flat.set/flat.set.iterators/reverse_iterator.pass.cpp | 2 --
4 files changed, 8 deletions(-)
diff --git a/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
index 7a111e228c115..b4d76aac119a3 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/reverse_iterator.pass.cpp
@@ -19,11 +19,9 @@
// const_reverse_iterator crend() const noexcept;
#include <cassert>
-#include <cstddef>
#include <deque>
#include <flat_map>
#include <functional>
-#include <vector>
#include <iterator>
diff --git a/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
index 35b2b9f8a9e7e..6e29d209f83f0 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/reverse_iterator.pass.cpp
@@ -21,11 +21,9 @@
// const_reverse_iterator crend() const noexcept;
#include <cassert>
-#include <cstddef>
#include <deque>
#include <flat_map>
#include <functional>
-#include <vector>
#include <iterator>
diff --git a/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
index 76bd49b4abd9e..e25d786d9b3b4 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/reverse_iterator.pass.cpp
@@ -19,11 +19,9 @@
// const_reverse_iterator crend() const noexcept;
#include <cassert>
-#include <cstddef>
#include <deque>
#include <flat_set>
#include <functional>
-#include <vector>
#include <iterator>
diff --git a/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp b/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
index a9ef87d483e6f..4c2482cd0f3de 100644
--- a/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/reverse_iterator.pass.cpp
@@ -19,11 +19,9 @@
// const_reverse_iterator crend() const noexcept;
#include <cassert>
-#include <cstddef>
#include <deque>
#include <flat_set>
#include <functional>
-#include <vector>
#include <iterator>
More information about the libcxx-commits
mailing list