[libcxx-commits] [libcxx] [libc++] Add __assertion_handler as forwarding header (PR #134351)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> But #131031 requires `__assertion_handler` to be in the same directory with other normal headers along with `module.modulemap` file?
> 
> Currently, we have a libcxx subdrectory folk in https://chromium.googlesource.com/chromium/llvm-project/libcxx/, and using `__assertion_handler` in https://source.chromium.org/chromium/chromium/src/+/main:buildtools/third_party/libc++/__assertion_handler for non-module build. But the PR makes it not possible to use `__assertion_handler` in different place than `module.modulemap` dir.
> 
> Or do you think we should fix how we build libc++ in our side?

Yes. CMake is the only supported build tool, and we expect anybody using libc++ to use the same layout as we generate with CMake if you want to use your own build tool. I don't know exactly how you build your stuff, but it shouldn't be impossible to put your `__assertion_handler` in the right place.

https://github.com/llvm/llvm-project/pull/134351