[libcxx-commits] [libcxx] [libc++] Remove a few incorrect _LIBCPP_EXPORTED_FROM_ABI annotations (PR #132602)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 2 08:04:12 PDT 2025


================

----------------
ldionne wrote:

Please write a proper commit message! Benefits of this change:
- First, this means that we'll eventually be able to drop `HIDE_FROM_ABI` from these classes' methods (after applying `HIDE_FROM_ABI` to entire scopes). That would be impossible if we keep `EXPORTED_FROM_ABI` on the class, since that causes all of the class' methods to get exported.
- This reduces the likelihood of the attribute being copied around when it's not necessary.

Can you update the documentation of `_LIBCPP_EXPORTED_FROM_ABI` to mention *when* it should be used on classes? It's not super clear right now.

https://github.com/llvm/llvm-project/pull/132602


More information about the libcxx-commits mailing list