[libcxx-commits] [libcxx] [libc++] Remove _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS (PR #111964)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne approved this pull request.

This technically removes the `inline` keyword from the affected functions. Like we looked into a while back, it turns out that `inline` is used as an actual inlining hint by the compiler (contrary to what we've been taught in recent years by e.g. Chandler).

I am not too concerned about that, we looked through the functions and they are either very small (e.g. `string` functions) and should be inlined no matter what, or they are pretty large (e.g. `locale`) and shouldn't get inlined either way. But please call out this change explicitly in the commit message to make it easier to bisect in case someone needs to investigate a performance regression.

Also, just for due diligence, please run our string microbenchmarks before and after. I really don't think there will be any difference, but let's just make sure that we don't notice anything odd.

https://github.com/llvm/llvm-project/pull/111964