https://github.com/huixie90 requested changes to this pull request. Thanks for the patch. it looks really good. I started looking at the join_with_view.h and has not finished the header yet. https://github.com/llvm/llvm-project/pull/65536